You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jinmeiliao (GitHub)" <gi...@apache.org> on 2018/09/18 16:24:09 UTC
[GitHub] [geode] jinmeiliao opened pull request #2489: GEODE-3:
upgrade tomcat7/tomcat8 library to be java9 compatible
* upgrade dependency version
* exclude test lib to pull in a old version of xerces
* AuthConfigFactory needs to be turned off in the test with newer version of tomcat libs
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2489 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #2489: GEODE-3:
upgrade tomcat7/tomcat8 library to be java9 compatible
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
I was about to +1 and merge this in, but it looks like we've lost precheckin history since you've forced a push onto this branch.
For the sake of maintaining historical data, please don't force a push, even to your own fork, if you've opened a PR against the branch in question. Merge `develop` into your branch rather than rebasing, if necessary. The rebase can occur when the branch is ready to merge in, conveniently taken care of by GitHub when using the `Squash and merge` button.
[ Full content available at: https://github.com/apache/geode/pull/2489 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] metatype commented on pull request #2489: GEODE-3:
upgrade tomcat7/tomcat8 library to be java9 compatible
Posted by "metatype (GitHub)" <gi...@apache.org>.
If we upgrade the version of httpunit will it fix the terces issue (so we don't need a separate dependency)?
[ Full content available at: https://github.com/apache/geode/pull/2489 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #2489: GEODE-3:
upgrade tomcat7/tomcat8 library to be java9 compatible
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
httpunit is a stale component now. the last update is 2012
[ Full content available at: https://github.com/apache/geode/pull/2489 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] metatype commented on pull request #2489: GEODE-3:
upgrade tomcat7/tomcat8 library to be java9 compatible
Posted by "metatype (GitHub)" <gi...@apache.org>.
Just curious, what is this line doing?
[ Full content available at: https://github.com/apache/geode/pull/2489 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on issue #2489: GEODE-3:
upgrade tomcat7/tomcat8 library to be java9 compatible
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
@PurelyApplied I did not do any force push on this today, was it a week ago?
[ Full content available at: https://github.com/apache/geode/pull/2489 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #2489: GEODE-3:
upgrade tomcat7/tomcat8 library to be java9 compatible
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
the newer version of tomcat8 is expecting some sort of auth module being configured in web.xml if we don't do this.
[ Full content available at: https://github.com/apache/geode/pull/2489 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #2489: GEODE-3:
upgrade tomcat7/tomcat8 library to be java9 compatible
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
It's only in the test that we are disabling 3rd party authentication
[ Full content available at: https://github.com/apache/geode/pull/2489 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on issue #2489: GEODE-3:
upgrade tomcat7/tomcat8 library to be java9 compatible
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
@metatype can we merge this now?
[ Full content available at: https://github.com/apache/geode/pull/2489 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied closed pull request #2489: GEODE-3:
upgrade tomcat7/tomcat8 library to be java9 compatible
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
[ pull request closed by PurelyApplied ]
[ Full content available at: https://github.com/apache/geode/pull/2489 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org