You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Benjamin Bannier (JIRA)" <ji...@apache.org> on 2018/07/02 07:47:00 UTC

[jira] [Commented] (MESOS-8994) Ensure that the cmake build knows about all source files in the autotools build

    [ https://issues.apache.org/jira/browse/MESOS-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529490#comment-16529490 ] 

Benjamin Bannier commented on MESOS-8994:
-----------------------------------------

{noformat}
commit c0488797eaacbf6c07cb79235d1174718d933a2c
Author: Benjamin Bannier <be...@mesosphere.io>
Date:   Tue Jun 26 15:10:02 2018 -0700

    Added a support script to check for files missing in CMake.

    This compares the sources listed in the Autotools and CMake build
    files, and emits the difference. We use this to check if the builds
    have diverged, and how to reconcile that divergence.

    Review: https://reviews.apache.org/r/67707/
{noformat}

> Ensure that the cmake build knows about all source files in the autotools build
> -------------------------------------------------------------------------------
>
>                 Key: MESOS-8994
>                 URL: https://issues.apache.org/jira/browse/MESOS-8994
>             Project: Mesos
>          Issue Type: Improvement
>          Components: build, cmake
>            Reporter: Benjamin Bannier
>            Assignee: Benjamin Bannier
>            Priority: Critical
>
> We currently maintain two build systems in parallel with autotools still being used by the larger part of contributors and cmake catching up in terms of coverage and features.
>  
> This has lead to situations where certain features were added only to the autotools build while updating the cmake build was either implicitly (without creating a ticket) deferred or forgotten. Identifying such missing coverage makes it harder to gauge where the two build systems stand in terms of feature parity and how much work is left before autotools can be retired.
> We should update the cmake build setup to explicitly check whether any sources files (headers and sources) unknown to it exist in the tree. Until full parity is reached we would likely need to maintain a whitelist of files known to be missing in the cmake build (this whitelist would at the same time serve as a {{TODO}} list). The LLVM project uses the following function to perform closely related work, https://github.com/llvm-mirror/llvm/blob/master/cmake/modules/LLVMProcessSources.cmake#L70-L111.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)