You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/01 18:38:49 UTC
[GitHub] [spark] holdenk opened a new pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
holdenk opened a new pull request #28667:
URL: https://github.com/apache/spark/pull/28667
### What changes were proposed in this pull request?
Only push the release tag after the build has finished.
### Why are the changes needed?
If the build fails we don't need a release tag.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Running locally with a fake user
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-635605706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-635605706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637133404
**[Test build #123401 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123401/testReport)** for PR 28667 at commit [`9bd1dca`](https://github.com/apache/spark/commit/9bd1dca998926cfc7becb0737f58942c2ba5a770).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637176057
(looks like I forgot to push the commit I tested it with, pushed now)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637040991
**[Test build #123395 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123395/testReport)** for PR 28667 at commit [`9bd1dca`](https://github.com/apache/spark/commit/9bd1dca998926cfc7becb0737f58942c2ba5a770).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637040991
**[Test build #123395 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123395/testReport)** for PR 28667 at commit [`9bd1dca`](https://github.com/apache/spark/commit/9bd1dca998926cfc7becb0737f58942c2ba5a770).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637102436
Ok cool. I'm going to double check running it locally to make sure it the release still runs ok (I did a run last last week but just to be safe since we don't have any automated testing for these scripts), and once that's done I'll merge this and open a master & 3 PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637105517
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
dbtsai commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637098706
It does make sense to push the tag only on success, and let's merge it in 2.4, and then also send out PRs to both master / 3.0. Thanks for working on this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637131785
jenkins retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637105517
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-635683604
cc @dbtsai , too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637192463
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123401/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637177657
**[Test build #123403 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123403/testReport)** for PR 28667 at commit [`dd9e4a4`](https://github.com/apache/spark/commit/dd9e4a475d49d2ef7a1166c01889a4b9318baa2f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637173968
Tested build script locally, works ok :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637218481
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637153499
**[Test build #123395 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123395/testReport)** for PR 28667 at commit [`9bd1dca`](https://github.com/apache/spark/commit/9bd1dca998926cfc7becb0737f58942c2ba5a770).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637178207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637177657
**[Test build #123403 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123403/testReport)** for PR 28667 at commit [`dd9e4a4`](https://github.com/apache/spark/commit/dd9e4a475d49d2ef7a1166c01889a4b9318baa2f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637218481
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637192459
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637105525
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123393/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637037043
**[Test build #123393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123393/testReport)** for PR 28667 at commit [`d26c735`](https://github.com/apache/spark/commit/d26c7353e01442459f0c9d17dd013d0f61f2ad02).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637038321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28667:
URL: https://github.com/apache/spark/pull/28667#discussion_r433576803
##########
File path: dev/create-release/release-tag.sh
##########
@@ -24,7 +24,7 @@ function exit_with_usage {
local NAME=$(basename $0)
cat << EOF
usage: $NAME
-Tags a Spark release on a particular branch.
+Tags a Spark release on a particular branch. Must push after
Review comment:
uncompleted sentence `Must push after ...`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637154150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637133404
**[Test build #123401 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123401/testReport)** for PR 28667 at commit [`9bd1dca`](https://github.com/apache/spark/commit/9bd1dca998926cfc7becb0737f58942c2ba5a770).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637192148
**[Test build #123401 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123401/testReport)** for PR 28667 at commit [`9bd1dca`](https://github.com/apache/spark/commit/9bd1dca998926cfc7becb0737f58942c2ba5a770).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28667: [SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637007589
I don't know these scripts well, but yes we should only push on success. This looks sensible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637028852
I've got this for the 2.4 branch since I RMd the current release, I'm annoyed you closed this @dongjoon-hyun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637134368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-635603600
cc @dongjoon-hyun ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637104631
**[Test build #123393 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123393/testReport)** for PR 28667 at commit [`d26c735`](https://github.com/apache/spark/commit/d26c7353e01442459f0c9d17dd013d0f61f2ad02).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-635674156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637060894
Yeah I'll do a PR to master & branch-3.0 once I've gotten sign off on this being what we want to do (I know you had some reservations when we chatted).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637134368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637025021
Sorry, but I'll close this first to prevent accidental merge on this because `WIP` is removed.
Let's proceed this on `master` first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-635605135
**[Test build #123245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123245/testReport)** for PR 28667 at commit [`d26c735`](https://github.com/apache/spark/commit/d26c7353e01442459f0c9d17dd013d0f61f2ad02).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637025021
Sorry, but I'll close this first to prevent accidental merge on this.
Let's proceed this on `master` first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-635673782
**[Test build #123245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123245/testReport)** for PR 28667 at commit [`d26c735`](https://github.com/apache/spark/commit/d26c7353e01442459f0c9d17dd013d0f61f2ad02).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-635605135
**[Test build #123245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123245/testReport)** for PR 28667 at commit [`d26c735`](https://github.com/apache/spark/commit/d26c7353e01442459f0c9d17dd013d0f61f2ad02).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28667:
URL: https://github.com/apache/spark/pull/28667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637034996
This is reopened according to @holdenk 's request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637038321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637218309
previously I delete the tags if something goes wrong. This looks like a better solution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637218132
**[Test build #123403 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123403/testReport)** for PR 28667 at commit [`dd9e4a4`](https://github.com/apache/spark/commit/dd9e4a475d49d2ef7a1166c01889a4b9318baa2f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk closed pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
holdenk closed pull request #28667:
URL: https://github.com/apache/spark/pull/28667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637192459
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637178207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637005611
cc @srowen & @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-635625346
cc @shaneknapp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-635674156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637037043
**[Test build #123393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123393/testReport)** for PR 28667 at commit [`d26c735`](https://github.com/apache/spark/commit/d26c7353e01442459f0c9d17dd013d0f61f2ad02).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28667: [WIP][SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637154150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28667: [SPARK-31860][BUILD][2.4] only push release tags on success
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28667:
URL: https://github.com/apache/spark/pull/28667#issuecomment-637201132
Only test failure is unit test, unrelated and different than the last test failures. I'm going to merge this to branch-2.4 now. There is a separate PR to master at https://github.com/apache/spark/pull/28700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org