You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by PSUdaemon <gi...@git.apache.org> on 2016/08/24 01:08:02 UTC
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
GitHub user PSUdaemon opened a pull request:
https://github.com/apache/trafficserver/pull/909
TS-3508: Use accept4() on systems where it is available and emulate w\u2026
\u2026here it is not.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PSUdaemon/trafficserver ts-3508-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #909
----
commit 5dff1909c03e156bb123a8dd861592163d0b27c6
Author: Phil Sorber <so...@apache.org>
Date: 2016-08-23T16:10:34Z
TS-3508: Use accept4() on systems where it is available and emulate where it is not.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76104710
--- Diff: iocore/eventsystem/P_UnixSocketManager.h ---
@@ -55,21 +55,52 @@ transient_error()
return transient;
}
+#if !HAVE_ACCEPT4
+int
+accept4(int sockfd, struct sockaddr *addr, socklen_t *addrlen, int flags)
+{
+ int fd, err;
--- End diff --
Maybe use `ats_scoped_fd` here, makes clean up a bit simpler.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76362179
--- Diff: iocore/eventsystem/I_SocketManager.h ---
@@ -37,6 +37,14 @@
#include "I_EventSystem.h"
#include "I_Thread.h"
+#ifndef SOCK_NONBLOCK
+#define SOCK_NONBLOCK O_NONBLOCK
+#endif
+
+#ifndef SOCK_CLOEXEC
+#define SOCK_CLOEXEC O_CLOEXEC
--- End diff --
Pretty sure OS X doesn't have ``O_CLOEXEC``. Also the ``eventfd`` code uses ``FD_CLOEXEC`` where ``O_CLOEXEC`` would be more correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon closed the pull request at:
https://github.com/apache/trafficserver/pull/909
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76104639
--- Diff: iocore/eventsystem/I_SocketManager.h ---
@@ -102,7 +110,7 @@ struct SocketManager {
int dup(int s);
// result is the fd or -errno
- int accept(int s, struct sockaddr *addr, socklen_t *addrlen);
+ int accept4(int s, struct sockaddr *addr, socklen_t *addrlen, int flags = 0);
--- End diff --
I'd leave this as `accept`, no need to drag in external naming conventions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/909
I see what is being done here but I'm not sure I like defining a global that is an alternate syscall. I would probably go with having an `accept4` method in `SocketManager` that is called from the public `accept` and is conditionally defined as the alternate implementation or an inline call to `accept4` and depend on the compiler to optimize out the method call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/520/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/593/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76107280
--- Diff: iocore/eventsystem/I_SocketManager.h ---
@@ -102,7 +110,7 @@ struct SocketManager {
int dup(int s);
// result is the fd or -errno
- int accept(int s, struct sockaddr *addr, socklen_t *addrlen);
+ int accept4(int s, struct sockaddr *addr, socklen_t *addrlen, int flags = 0);
--- End diff --
I was on the fence about this. I went with the new name because we have a lot of `accept()` functions floating around and I wanted the change to be clear. Also, since we are bringing in the new API by emulating `accept4()` on platforms where it didn't exist, I figured the name change made sense. Do any others have an opinion about this? @jpeach? @zwoop?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/516/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/490/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/620/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76105672
--- Diff: iocore/eventsystem/P_UnixSocketManager.h ---
@@ -55,21 +55,52 @@ transient_error()
return transient;
}
+#if !HAVE_ACCEPT4
+int
+accept4(int sockfd, struct sockaddr *addr, socklen_t *addrlen, int flags)
+{
+ int fd, err;
+
+ do {
+ fd = accept(sockfd, addr, addrlen);
+ if (likely(fd >= 0))
+ break;
+ } while (transient_error());
+
+ if ((fd >= 0) && (flags & SOCK_CLOEXEC) && (safe_fcntl(fd, F_SETFD, FD_CLOEXEC) < 0)) {
+ err = errno;
+ close(fd);
+ errno = err;
+ return -1;
+ }
+
+ if ((fd >= 0) && (flags & SOCK_NONBLOCK) && (safe_nonblocking(fd) < 0)) {
+ err = errno;
+ close(fd);
+ errno = err;
+ return -1;
+ }
+
+ return fd;
+}
+#endif
--- End diff --
I don't understand what you mean by this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76361930
--- Diff: iocore/eventsystem/P_UnixSocketManager.h ---
@@ -55,21 +55,52 @@ transient_error()
return transient;
}
+#if !HAVE_ACCEPT4
+int
+accept4(int sockfd, struct sockaddr *addr, socklen_t *addrlen, int flags)
+{
+ int fd, err;
--- End diff --
Unfortunately ``ats_scoped_fd`` won't preserve errno. The ``SocketManager`` routines are inconsistent about whether they return the error or set ``errno``. If you can clean than up (separately?) then ``ats_scoped_fd`` is a good option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76436699
--- Diff: iocore/eventsystem/I_SocketManager.h ---
@@ -37,6 +37,14 @@
#include "I_EventSystem.h"
#include "I_Thread.h"
+#ifndef SOCK_NONBLOCK
+#define SOCK_NONBLOCK O_NONBLOCK
+#endif
+
+#ifndef SOCK_CLOEXEC
+#define SOCK_CLOEXEC O_CLOEXEC
--- End diff --
> $ grep CLOEXEC /usr/include/sys/fcntl.h
> #define O_CLOEXEC 0x1000000 /* implicitly set FD_CLOEXEC */
On OS X 10.10.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/624/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76106900
--- Diff: iocore/eventsystem/P_UnixSocketManager.h ---
@@ -55,21 +55,52 @@ transient_error()
return transient;
}
+#if !HAVE_ACCEPT4
+int
+accept4(int sockfd, struct sockaddr *addr, socklen_t *addrlen, int flags)
+{
+ int fd, err;
--- End diff --
How does this play with errno? I got specific feedback about saving and restoring errno around `close()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76435818
--- Diff: iocore/eventsystem/I_SocketManager.h ---
@@ -37,6 +37,14 @@
#include "I_EventSystem.h"
#include "I_Thread.h"
+#ifndef SOCK_NONBLOCK
+#define SOCK_NONBLOCK O_NONBLOCK
+#endif
+
+#ifndef SOCK_CLOEXEC
+#define SOCK_CLOEXEC O_CLOEXEC
--- End diff --
\U0001f43c
That is specified in POSIX.1-2008. This is why we can't have nice things...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/594/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76437047
--- Diff: iocore/eventsystem/I_SocketManager.h ---
@@ -37,6 +37,14 @@
#include "I_EventSystem.h"
#include "I_Thread.h"
+#ifndef SOCK_NONBLOCK
+#define SOCK_NONBLOCK O_NONBLOCK
+#endif
+
+#ifndef SOCK_CLOEXEC
+#define SOCK_CLOEXEC O_CLOEXEC
--- End diff --
\U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/596/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/518/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76436860
--- Diff: iocore/eventsystem/I_SocketManager.h ---
@@ -37,6 +37,14 @@
#include "I_EventSystem.h"
#include "I_Thread.h"
+#ifndef SOCK_NONBLOCK
+#define SOCK_NONBLOCK O_NONBLOCK
+#endif
+
+#ifndef SOCK_CLOEXEC
+#define SOCK_CLOEXEC O_CLOEXEC
--- End diff --
Also have evidence that it exists on 10.9.5.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/489/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76104871
--- Diff: iocore/eventsystem/P_UnixSocketManager.h ---
@@ -55,21 +55,52 @@ transient_error()
return transient;
}
+#if !HAVE_ACCEPT4
+int
+accept4(int sockfd, struct sockaddr *addr, socklen_t *addrlen, int flags)
+{
+ int fd, err;
+
+ do {
+ fd = accept(sockfd, addr, addrlen);
+ if (likely(fd >= 0))
+ break;
+ } while (transient_error());
+
+ if ((fd >= 0) && (flags & SOCK_CLOEXEC) && (safe_fcntl(fd, F_SETFD, FD_CLOEXEC) < 0)) {
+ err = errno;
+ close(fd);
+ errno = err;
+ return -1;
+ }
+
+ if ((fd >= 0) && (flags & SOCK_NONBLOCK) && (safe_nonblocking(fd) < 0)) {
+ err = errno;
+ close(fd);
+ errno = err;
+ return -1;
+ }
+
+ return fd;
+}
+#endif
--- End diff --
`#else` so the literal `accept4` isn't compiled in places where it doesn't exist?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/622/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76361941
--- Diff: iocore/eventsystem/I_SocketManager.h ---
@@ -102,7 +110,7 @@ struct SocketManager {
int dup(int s);
// result is the fd or -errno
- int accept(int s, struct sockaddr *addr, socklen_t *addrlen);
+ int accept4(int s, struct sockaddr *addr, socklen_t *addrlen, int flags = 0);
--- End diff --
``accept()`` works for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/492/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/488/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #909: TS-3508: Use accept4() on systems where it is avai...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/909
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/592/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---