[GitHub] [incubator-doris] morningman commented on a change in pull request #2867: Fix bug that _min_percentage_of_error_disk was not initialized

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #2867: Fix bug that _min_percentage_of_error_disk was not initialized
URL: https://github.com/apache/incubator-doris/pull/2867#discussion_r376836945
 
 

 ##########
 File path: be/src/common/config.h
 ##########
 @@ -203,7 +203,8 @@ namespace config {
     CONF_Int32(disk_stat_monitor_interval, "5");
     CONF_Int32(unused_rowset_monitor_interval, "30");
     CONF_String(storage_root_path, "${DORIS_HOME}/storage");
-    CONF_Int32(min_percentage_of_error_disk, "50");
+    // BE process will exit if the percentage of error disk reach this value.
+    CONF_Int32(max_percentage_of_error_disk, "50");
 
 Review comment:
   How about set the default to 0 to make it strict, so that we won't miss the broken disks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org