[GitHub] [pulsar] hangc0276 commented on a change in pull request #14348: Expose BookKeeper client thread pool metrics

[GitBox <gi...@apache.org>]

hangc0276 commented on a change in pull request #14348:
URL: https://github.com/apache/pulsar/pull/14348#discussion_r814603512



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/ManagedLedgerClientFactory.java
##########
@@ -93,7 +93,7 @@ public void initialize(ServiceConfiguration conf, MetadataStoreExtended metadata
                     try {
                         return bookkeeperProvider.create(conf, metadataStore, eventLoopGroup,
                                 Optional.ofNullable(ensemblePlacementPolicyConfig.getPolicyClass()),
-                                ensemblePlacementPolicyConfig.getProperties());
+                                ensemblePlacementPolicyConfig.getProperties(), statsLogger);

Review comment:
       @Shawyeok Thanks for your feedback. I generate bk client ordered thread pool metrics name by `ISOLATION_BOOKIE_GROUPS` name configured in `ensemblePlacementPolicyConfig`. So that different bk client has different metric name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org