You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/10 06:55:14 UTC
[GitHub] [hudi] AirToSupply opened a new pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
AirToSupply opened a new pull request #4548:
URL: https://github.com/apache/hudi/pull/4548
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
hudi-flink module support timestamp-micros. [(HUDI-3184)](https://issues.apache.org/jira/browse/HUDI-3184)
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009689155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83b5d6d0346dbb0d11796f2e70d76f6f92d64632 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008613232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afe7fac6c45a7ee1f0935e17896d0616f124fca3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #4548:
URL: https://github.com/apache/hudi/pull/4548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009762952
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e4747081e213a19e1ecc13a473bb1a960503d59 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008585610
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afe7fac6c45a7ee1f0935e17896d0616f124fca3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009821204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
}, {
"hash" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100",
"triggerID" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e4747081e213a19e1ecc13a473bb1a960503d59 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095)
* 17e6507a5b985b01ff2a74a9999d596ce1e5ffeb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009642387
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed10ca789674ce963ab430d0656b1e05d3bb6a70 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052)
* 83b5d6d0346dbb0d11796f2e70d76f6f92d64632 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009887891
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
}, {
"hash" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100",
"triggerID" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"triggerType" : "PUSH"
}, {
"hash" : "6b6822f83b8930d9ee618834fbaf21d5d11f5ced",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6b6822f83b8930d9ee618834fbaf21d5d11f5ced",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17e6507a5b985b01ff2a74a9999d596ce1e5ffeb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100)
* 6b6822f83b8930d9ee618834fbaf21d5d11f5ced UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008659086
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afe7fac6c45a7ee1f0935e17896d0616f124fca3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047)
* ed10ca789674ce963ab430d0656b1e05d3bb6a70 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009707398
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83b5d6d0346dbb0d11796f2e70d76f6f92d64632 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092)
* 6e4747081e213a19e1ecc13a473bb1a960503d59 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009762952
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e4747081e213a19e1ecc13a473bb1a960503d59 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008586981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afe7fac6c45a7ee1f0935e17896d0616f124fca3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008657065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afe7fac6c45a7ee1f0935e17896d0616f124fca3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047)
* ed10ca789674ce963ab430d0656b1e05d3bb6a70 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009890247
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
}, {
"hash" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100",
"triggerID" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"triggerType" : "PUSH"
}, {
"hash" : "6b6822f83b8930d9ee618834fbaf21d5d11f5ced",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5101",
"triggerID" : "6b6822f83b8930d9ee618834fbaf21d5d11f5ced",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17e6507a5b985b01ff2a74a9999d596ce1e5ffeb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100)
* 6b6822f83b8930d9ee618834fbaf21d5d11f5ced Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5101)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009642387
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed10ca789674ce963ab430d0656b1e05d3bb6a70 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052)
* 83b5d6d0346dbb0d11796f2e70d76f6f92d64632 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009707398
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83b5d6d0346dbb0d11796f2e70d76f6f92d64632 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092)
* 6e4747081e213a19e1ecc13a473bb1a960503d59 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009817428
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
}, {
"hash" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e4747081e213a19e1ecc13a473bb1a960503d59 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095)
* 17e6507a5b985b01ff2a74a9999d596ce1e5ffeb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008748486
Thanks for the contribution, i have left some comments ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008585610
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afe7fac6c45a7ee1f0935e17896d0616f124fca3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009643704
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed10ca789674ce963ab430d0656b1e05d3bb6a70 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052)
* 83b5d6d0346dbb0d11796f2e70d76f6f92d64632 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009709828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83b5d6d0346dbb0d11796f2e70d76f6f92d64632 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092)
* 6e4747081e213a19e1ecc13a473bb1a960503d59 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009890247
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
}, {
"hash" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100",
"triggerID" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"triggerType" : "PUSH"
}, {
"hash" : "6b6822f83b8930d9ee618834fbaf21d5d11f5ced",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5101",
"triggerID" : "6b6822f83b8930d9ee618834fbaf21d5d11f5ced",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17e6507a5b985b01ff2a74a9999d596ce1e5ffeb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100)
* 6b6822f83b8930d9ee618834fbaf21d5d11f5ced Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5101)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009932126
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
}, {
"hash" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100",
"triggerID" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"triggerType" : "PUSH"
}, {
"hash" : "6b6822f83b8930d9ee618834fbaf21d5d11f5ced",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5101",
"triggerID" : "6b6822f83b8930d9ee618834fbaf21d5d11f5ced",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b6822f83b8930d9ee618834fbaf21d5d11f5ced Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5101)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008586981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afe7fac6c45a7ee1f0935e17896d0616f124fca3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009689155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83b5d6d0346dbb0d11796f2e70d76f6f92d64632 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009817428
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
}, {
"hash" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e4747081e213a19e1ecc13a473bb1a960503d59 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095)
* 17e6507a5b985b01ff2a74a9999d596ce1e5ffeb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008613232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afe7fac6c45a7ee1f0935e17896d0616f124fca3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009709828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83b5d6d0346dbb0d11796f2e70d76f6f92d64632 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092)
* 6e4747081e213a19e1ecc13a473bb1a960503d59 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008698102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed10ca789674ce963ab430d0656b1e05d3bb6a70 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#discussion_r781046612
##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/format/cow/Int64TimestampColumnReader.java
##########
@@ -75,22 +84,38 @@ protected void readBatchFromDictionaryIds(
for (int i = rowId; i < rowId + num; ++i) {
if (!column.isNullAt(i)) {
column.setTimestamp(i, decodeInt64ToTimestamp(
- utcTimestamp, dictionary, dictionaryIds.getInt(i)));
+ utcTimestamp, dictionary, dictionaryIds.getInt(i), unit));
}
}
}
public static TimestampData decodeInt64ToTimestamp(
boolean utcTimestamp,
org.apache.parquet.column.Dictionary dictionary,
- int id) {
+ int id,
+ LogicalTypeAnnotation.TimeUnit unit) {
long value = dictionary.decodeToLong(id);
- return int64ToTimestamp(utcTimestamp, value);
+ return int64ToTimestamp(utcTimestamp, value, unit);
}
- private static TimestampData int64ToTimestamp(boolean utcTimestamp, long millionsOfDay) {
+ private static TimestampData int64ToTimestamp(
+ boolean utcTimestamp,
+ long millionsOfDay,
+ LogicalTypeAnnotation.TimeUnit unit) {
if (utcTimestamp) {
- return TimestampData.fromEpochMillis(millionsOfDay, 0);
+ final ChronoUnit chronoUnit;
+ switch (unit) {
+ case MILLIS:
+ chronoUnit = ChronoUnit.MILLIS;
+ break;
Review comment:
I guess the `chronoUnit` can be a class member variable right ?
And, we should also fix the non-utc timezone code path.
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StringToRowDataConverter.java
##########
@@ -104,4 +109,21 @@ private static Converter getConverter(LogicalType logicalType) {
"Unsupported type " + logicalType.getTypeRoot() + " for " + StringToRowDataConverter.class.getName());
}
}
+
+ private static TimestampData convertToTimestamp(long timestamp, TimestampType logicalType) {
+ final int precision = logicalType.getPrecision();
Review comment:
Same as `RowDataToAvroConverters`, instantiate two converters here.
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/AvroToRowDataConverters.java
##########
@@ -125,7 +129,7 @@ private static AvroToRowDataConverter createConverter(LogicalType type) {
case TIME_WITHOUT_TIME_ZONE:
return AvroToRowDataConverters::convertToTime;
case TIMESTAMP_WITHOUT_TIME_ZONE:
- return AvroToRowDataConverters::convertToTimestamp;
+ return avroObject -> convertToTimestamp(avroObject, (TimestampType) type);
case CHAR:
Review comment:
We can also instantiate the `chronoUnit` first based on the `type` precision.
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/AvroToRowDataConverters.java
##########
@@ -200,22 +204,36 @@ private static AvroToRowDataConverter createMapConverter(LogicalType type) {
};
}
- private static TimestampData convertToTimestamp(Object object) {
- final long millis;
+ private static TimestampData convertToTimestamp(Object object, TimestampType logicalType) {
+ final long timestamp;
if (object instanceof Long) {
- millis = (Long) object;
+ timestamp = (Long) object;
} else if (object instanceof Instant) {
- millis = ((Instant) object).toEpochMilli();
+ timestamp = ((Instant) object).toEpochMilli();
} else {
JodaConverter jodaConverter = JodaConverter.getConverter();
if (jodaConverter != null) {
- millis = jodaConverter.convertTimestamp(object);
+ timestamp = jodaConverter.convertTimestamp(object);
} else {
throw new IllegalArgumentException(
"Unexpected object type for TIMESTAMP logical type. Received: " + object);
}
}
- return TimestampData.fromEpochMillis(millis);
+
+ final int precision = logicalType.getPrecision();
+ final ChronoUnit chronoUnit;
+ if (precision <= 3) {
+ chronoUnit = ChronoUnit.MILLIS;
+ } else if (precision <= 6) {
+ chronoUnit = ChronoUnit.MICROS;
+ } else {
+ throw new IllegalArgumentException(
+ "Avro does not support TIMESTAMP type with precision: "
+ + precision
+ + ", it only supports precision less than 6.");
+ }
+ return TimestampData.fromLocalDateTime(
+ LocalDateTime.ofInstant(Instant.ofEpochSecond(0).plus(timestamp, chronoUnit), ZoneId.systemDefault()));
Review comment:
We should utc timezone here:
```java
TimestampData.fromInstant(Instant.EPOCH.plus(timestamp, chronoUnit))
```
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/RowDataToAvroConverters.java
##########
@@ -157,7 +162,15 @@ public Object convert(Schema schema, Object object) {
@Override
public Object convert(Schema schema, Object object) {
- return ((TimestampData) object).toInstant().toEpochMilli();
+ final LocalDateTime now = ((TimestampData) object).toLocalDateTime();
+ final ZoneOffset offset = ZoneOffset.systemDefault().getRules().getOffset(LocalDateTime.now());
+ if (schema.getLogicalType() instanceof LogicalTypes.TimestampMillis) {
+ return now.toInstant(offset).toEpochMilli();
+ } else if (schema.getLogicalType() instanceof LogicalTypes.TimestampMicros) {
Review comment:
We can instantiate two converters like this:
```java
TimestampType timestampType = (TimestampType) type;
if (timestampType.getPrecision() <= 3) {
converter =
new RowDataToAvroConverter() {
private static final long serialVersionUID = 1L;
@Override
public Object convert(Schema schema, Object object) {
return ((TimestampData) object).toInstant().toEpochMilli();
}
};
} else if (timestampType.getPrecision() <= 6) {
converter =
new RowDataToAvroConverter() {
private static final long serialVersionUID = 1L;
@Override
public Object convert(Schema schema, Object object) {
return ChronoUnit.MICROS.between(Instant.EPOCH, ((TimestampData) object).toInstant());
}
};
} else {
throw new UnsupportedOperationException("Unsupported type: " + type);
}
```
##########
File path: hudi-flink/src/test/java/org/apache/hudi/utils/TestStringToRowDataConverter.java
##########
@@ -98,10 +108,30 @@ void testRowDataToAvroStringToRowData() {
final String[] recordKeys = KeyGenUtils.extractRecordKeys(recordKey);
Object[] convertedKeys = stringToRowDataConverter.convert(recordKeys);
- GenericRowData converted = new GenericRowData(6);
- for (int i = 0; i < 6; i++) {
+ GenericRowData converted = new GenericRowData(7);
+ for (int i = 0; i < 7; i++) {
converted.setField(i, convertedKeys[i]);
}
assertThat(converted, is(rowData));
}
+
+ private TimestampData stringToTimestampData(String timestamp) {
+ return TimestampData.fromLocalDateTime(LocalDateTime.parse(timestamp));
+ }
+
+ private long timestampDataToLong(TimestampData timestamp, ChronoUnit unit) {
+ final LocalDateTime now = timestamp.toLocalDateTime();
+ final ZoneOffset offset = ZoneOffset.systemDefault().getRules().getOffset(LocalDateTime.now());
+ switch (unit) {
+ case MILLIS:
+ return TimeUnit.SECONDS.toMillis(now.toEpochSecond(offset))
+ + now.toInstant(offset).getLong(ChronoField.MILLI_OF_SECOND);
Review comment:
Can we convert the `TimestampData` to `Instant` first then to the long then ? It is more concise i think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008698102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed10ca789674ce963ab430d0656b1e05d3bb6a70 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#discussion_r781801961
##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/format/cow/Int64TimestampColumnReader.java
##########
@@ -75,25 +90,29 @@ protected void readBatchFromDictionaryIds(
for (int i = rowId; i < rowId + num; ++i) {
if (!column.isNullAt(i)) {
column.setTimestamp(i, decodeInt64ToTimestamp(
- utcTimestamp, dictionary, dictionaryIds.getInt(i)));
+ utcTimestamp, dictionary, dictionaryIds.getInt(i), chronoUnit));
}
}
}
public static TimestampData decodeInt64ToTimestamp(
boolean utcTimestamp,
org.apache.parquet.column.Dictionary dictionary,
- int id) {
+ int id,
+ ChronoUnit unit) {
long value = dictionary.decodeToLong(id);
- return int64ToTimestamp(utcTimestamp, value);
+ return int64ToTimestamp(utcTimestamp, value, unit);
}
- private static TimestampData int64ToTimestamp(boolean utcTimestamp, long millionsOfDay) {
+ private static TimestampData int64ToTimestamp(
+ boolean utcTimestamp,
+ long millionsOfDay,
+ ChronoUnit unit) {
Review comment:
millionsOfDay => interval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009821204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
}, {
"hash" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100",
"triggerID" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e4747081e213a19e1ecc13a473bb1a960503d59 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095)
* 17e6507a5b985b01ff2a74a9999d596ce1e5ffeb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009887891
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
}, {
"hash" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5095",
"triggerID" : "6e4747081e213a19e1ecc13a473bb1a960503d59",
"triggerType" : "PUSH"
}, {
"hash" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100",
"triggerID" : "17e6507a5b985b01ff2a74a9999d596ce1e5ffeb",
"triggerType" : "PUSH"
}, {
"hash" : "6b6822f83b8930d9ee618834fbaf21d5d11f5ced",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6b6822f83b8930d9ee618834fbaf21d5d11f5ced",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17e6507a5b985b01ff2a74a9999d596ce1e5ffeb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5100)
* 6b6822f83b8930d9ee618834fbaf21d5d11f5ced UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1009643704
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
}, {
"hash" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092",
"triggerID" : "83b5d6d0346dbb0d11796f2e70d76f6f92d64632",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed10ca789674ce963ab430d0656b1e05d3bb6a70 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052)
* 83b5d6d0346dbb0d11796f2e70d76f6f92d64632 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5092)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008659086
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afe7fac6c45a7ee1f0935e17896d0616f124fca3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047)
* ed10ca789674ce963ab430d0656b1e05d3bb6a70 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5052)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4548: [HUDI-3184] hudi-flink support timestamp-micros
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4548:
URL: https://github.com/apache/hudi/pull/4548#issuecomment-1008657065
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047",
"triggerID" : "afe7fac6c45a7ee1f0935e17896d0616f124fca3",
"triggerType" : "PUSH"
}, {
"hash" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ed10ca789674ce963ab430d0656b1e05d3bb6a70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afe7fac6c45a7ee1f0935e17896d0616f124fca3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5047)
* ed10ca789674ce963ab430d0656b1e05d3bb6a70 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org