You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Timothy Bish (JIRA)" <ji...@apache.org> on 2018/10/03 16:16:00 UTC

[jira] [Resolved] (PROTON-1948) Refactor FrameWriter to avoid reencodes when buffer space is insufficient

     [ https://issues.apache.org/jira/browse/PROTON-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved PROTON-1948.
----------------------------------
    Resolution: Fixed

> Refactor FrameWriter to avoid reencodes when buffer space is insufficient
> -------------------------------------------------------------------------
>
>                 Key: PROTON-1948
>                 URL: https://issues.apache.org/jira/browse/PROTON-1948
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-j
>    Affects Versions: proton-j-0.29.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: proton-j-0.30.0
>
>
> The current FrameWriter implementation uses a ByteBuffer wrapped in a ReadableBuffer to encode to and if the buffer is to small it recreates the buffer with a larger size and must perform a second encode to finish the job.  We can now implement our own ReadableBuffer type for the writer that both performs better by dropping the ByteBuffer abstractions and that grows as needed to fit the encoding of the types and the accompanying payloads (for Transfers).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org