You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/02/19 02:24:01 UTC

[GitHub] [pulsar] nlu90 opened a new pull request #6361: [Issue 6317][function] remove future.join() from PulsarSinkEffectivelyOnceProcessor

nlu90 opened a new pull request #6361: [Issue 6317][function] remove future.join() from PulsarSinkEffectivelyOnceProcessor
URL: https://github.com/apache/pulsar/pull/6361
 
 
   Fixes #6317 
   
   ### Motivation
   Remove unnecessary wait to improve the throughput with EFFECTIVELY_ONCE processing guarantee.
   
   ### Modifications
   
   - remove the `future.join` from the `PulsarSinkEffectivelyOnceProcessor`
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat merged pull request #6361: [Issue 6317][function] remove future.join() from PulsarSinkEffectivelyOnceProcessor

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #6361: [Issue 6317][function] remove future.join() from PulsarSinkEffectivelyOnceProcessor
URL: https://github.com/apache/pulsar/pull/6361
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services