You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/01/27 20:13:14 UTC

[GitHub] [ozone] adoroszlai opened a new pull request, #4217: HDDS-7778. Add metrics for push replication

adoroszlai opened a new pull request, #4217:
URL: https://github.com/apache/ozone/pull/4217

   ## What changes were proposed in this pull request?
   
   Reuse existing `MeasuredReplicator` wrapper to register metrics for push replication, too.
   
   https://issues.apache.org/jira/browse/HDDS-7778
   
   ## How was this patch tested?
   
   Ran replication test (copied from `ozonesecure`) in `ozone` compose environment:
   
   ```
   start_docker_env 3
   
   execute_robot_test scm basic/basic.robot
   
   execute_robot_test scm admincli/container.robot
   
   # test replication
   docker-compose up -d --scale datanode=2
   execute_robot_test scm -v container:1 -v count:2 replication/wait.robot
   docker-compose up -d --scale datanode=3
   execute_robot_test scm -v container:1 -v count:3 replication/wait.robot
   ```
   
   Datanode log:
   
   ```
   [ContainerReplicationThread-0] INFO replication.GrpcOutputStream: Sent 30208 bytes for container 1
   ```
   
   Verified metrics via JMX:
   
   ```
   {
     "name" : "Hadoop:service=HddsDatanode,name=ContainerReplicator/push",
     "modelerType" : "ContainerReplicator/push",
     "tag.Context" : "dfs",
     "tag.Hostname" : "afeb2cccdbb9",
     "Failure" : 0,
     "FailureBytes" : 0,
     "FailureTime" : 0,
     "QueueTime" : 3,
     "Success" : 1,
     "SuccessTime" : 245,
     "TransferredBytes" : 30208
   }
   ```
   
   Regular CI:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/4026673527


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] sodonnel merged pull request #4217: HDDS-7778. Add metrics for push replication

Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel merged PR #4217:
URL: https://github.com/apache/ozone/pull/4217


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai commented on pull request #4217: HDDS-7778. Add metrics for push replication

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4217:
URL: https://github.com/apache/ozone/pull/4217#issuecomment-1409327376

   Thanks @sodonnel for reviewing and committing it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kerneltime commented on pull request #4217: HDDS-7778. Add metrics for push replication

Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #4217:
URL: https://github.com/apache/ozone/pull/4217#issuecomment-1408993617

   @xBis7 can you please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org