You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2017/08/18 13:32:43 UTC
Review Request 61732: Updated endpoints help.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61732/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Till Toenshoff.
Repository: mesos
Description
-------
Updated endpoints help.
Diffs
-----
docs/endpoints/index.md eb88154aaa46c340112acee149c716cf32a495bb
docs/endpoints/master/tasks.json.md f6b808d1ab2539f5754860f3b582d864482a6e8b
docs/endpoints/master/tasks.md da04c9f48a612371a5ae167dafe2ac80bf11009f
docs/endpoints/slave/api/v1/resource_provider.md PRE-CREATION
Diff: https://reviews.apache.org/r/61732/diff/1/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 61732: Updated endpoints help.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61732/#review183240
-----------------------------------------------------------
Bad patch!
Reviews applied: [61732, 61745, 61733, 61731]
Failed command: python support/apply-reviews.py -n -r 61731
Error:
error: patch failed: docs/configuration.md:1649
error: docs/configuration.md: patch does not apply
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/252/console
- Mesos Reviewbot Windows
On Aug. 18, 2017, 5:24 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61732/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 5:24 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated endpoints help.
>
>
> Diffs
> -----
>
> docs/endpoints/index.md eb88154aaa46c340112acee149c716cf32a495bb
> docs/endpoints/master/frameworks.md 1a7950a935c6ad7b23798e55f65f08d7db671135
> docs/endpoints/master/slaves.md f9bb7ef8dfa007a98fa64e00c7ad8fbfb32ea901
> docs/endpoints/master/tasks.json.md f6b808d1ab2539f5754860f3b582d864482a6e8b
> docs/endpoints/master/tasks.md da04c9f48a612371a5ae167dafe2ac80bf11009f
> docs/endpoints/slave/api/v1/resource_provider.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61732/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 61732: Updated endpoints help.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61732/
-----------------------------------------------------------
(Updated Aug. 18, 2017, 1:24 p.m.)
Review request for mesos, Anand Mazumdar and Till Toenshoff.
Repository: mesos
Description
-------
Updated endpoints help.
Diffs (updated)
-----
docs/endpoints/index.md eb88154aaa46c340112acee149c716cf32a495bb
docs/endpoints/master/frameworks.md 1a7950a935c6ad7b23798e55f65f08d7db671135
docs/endpoints/master/slaves.md f9bb7ef8dfa007a98fa64e00c7ad8fbfb32ea901
docs/endpoints/master/tasks.json.md f6b808d1ab2539f5754860f3b582d864482a6e8b
docs/endpoints/master/tasks.md da04c9f48a612371a5ae167dafe2ac80bf11009f
docs/endpoints/slave/api/v1/resource_provider.md PRE-CREATION
Diff: https://reviews.apache.org/r/61732/diff/3/
Changes: https://reviews.apache.org/r/61732/diff/2-3/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 61732: Updated endpoints help.
Posted by Till Toenshoff <to...@me.com>.
> On Aug. 18, 2017, 4:55 p.m., Till Toenshoff wrote:
> > docs/endpoints/slave/api/v1/resource_provider.md
> > Lines 12 (patched)
> > <https://reviews.apache.org/r/61732/diff/2/?file=1800019#file1800019line12>
> >
> > Not yours but the capitalizing here is inconsitent - we should possibly fix the source.
> >
> > "Local resource Provider" vs. "local resource provider" later in this document. Also why are "Call" and "Event" capitalized -- they are neither product nor company names.
> >
> > @anandmazumdar What do you think?
Actually "Call" and "Event" make sense as they are naming specific messages.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61732/#review183231
-----------------------------------------------------------
On Aug. 18, 2017, 1:48 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61732/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 1:48 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated endpoints help.
>
>
> Diffs
> -----
>
> docs/endpoints/index.md eb88154aaa46c340112acee149c716cf32a495bb
> docs/endpoints/master/frameworks.md 1a7950a935c6ad7b23798e55f65f08d7db671135
> docs/endpoints/master/slaves.md f9bb7ef8dfa007a98fa64e00c7ad8fbfb32ea901
> docs/endpoints/master/tasks.json.md f6b808d1ab2539f5754860f3b582d864482a6e8b
> docs/endpoints/master/tasks.md da04c9f48a612371a5ae167dafe2ac80bf11009f
> docs/endpoints/slave/api/v1/resource_provider.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61732/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 61732: Updated endpoints help.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61732/#review183231
-----------------------------------------------------------
Fix it, then Ship it!
docs/endpoints/master/frameworks.md
Lines 24 (patched)
<https://reviews.apache.org/r/61732/#comment259254>
s/framework ID specified/framework ID is specified/
docs/endpoints/slave/api/v1/resource_provider.md
Lines 12 (patched)
<https://reviews.apache.org/r/61732/#comment259255>
Not yours but the capitalizing here is inconsitent - we should possibly fix the source.
"Local resource Provider" vs. "local resource provider" later in this document. Also why are "Call" and "Event" capitalized -- they are neither product nor company names.
@anandmazumdar What do you think?
- Till Toenshoff
On Aug. 18, 2017, 1:48 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61732/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 1:48 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated endpoints help.
>
>
> Diffs
> -----
>
> docs/endpoints/index.md eb88154aaa46c340112acee149c716cf32a495bb
> docs/endpoints/master/frameworks.md 1a7950a935c6ad7b23798e55f65f08d7db671135
> docs/endpoints/master/slaves.md f9bb7ef8dfa007a98fa64e00c7ad8fbfb32ea901
> docs/endpoints/master/tasks.json.md f6b808d1ab2539f5754860f3b582d864482a6e8b
> docs/endpoints/master/tasks.md da04c9f48a612371a5ae167dafe2ac80bf11009f
> docs/endpoints/slave/api/v1/resource_provider.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61732/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 61732: Updated endpoints help.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61732/
-----------------------------------------------------------
(Updated Aug. 18, 2017, 9:48 a.m.)
Review request for mesos, Anand Mazumdar and Till Toenshoff.
Repository: mesos
Description
-------
Updated endpoints help.
Diffs (updated)
-----
docs/endpoints/index.md eb88154aaa46c340112acee149c716cf32a495bb
docs/endpoints/master/frameworks.md 1a7950a935c6ad7b23798e55f65f08d7db671135
docs/endpoints/master/slaves.md f9bb7ef8dfa007a98fa64e00c7ad8fbfb32ea901
docs/endpoints/master/tasks.json.md f6b808d1ab2539f5754860f3b582d864482a6e8b
docs/endpoints/master/tasks.md da04c9f48a612371a5ae167dafe2ac80bf11009f
docs/endpoints/slave/api/v1/resource_provider.md PRE-CREATION
Diff: https://reviews.apache.org/r/61732/diff/2/
Changes: https://reviews.apache.org/r/61732/diff/1-2/
Testing
-------
Thanks,
Kapil Arya