You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "singhpk234 (via GitHub)" <gi...@apache.org> on 2023/04/21 04:08:26 UTC

[GitHub] [iceberg] singhpk234 commented on pull request #7391: Build: Run Iceberg Java Test with JDK 17

singhpk234 commented on PR #7391:
URL: https://github.com/apache/iceberg/pull/7391#issuecomment-1517230277

   Have added java 17 CI for all engine's as well, as part of commit [1bc99b8](https://github.com/apache/iceberg/pull/7391/commits/1bc99b805afe823604d9058b632af3135b3b5d1f), except Flink couldn't find minimum flink version since when java 17 is supported, found this issue https://issues.apache.org/jira/browse/FLINK-15736, but it seems un-resolved (cc @stevenzwu, who might have more context here)
   
   ---
   
   This has now added new CI's, i proposed idea a while back to reduce the load on main iceberg repo here (https://github.com/apache/iceberg/issues/5153#issuecomment-1179510026)  : 
   The idea is based on apache spark : 
   ```
   This is what Apache Spark does presently :
   
       We create a PR and our repository triggers the workflow. Our PR uses the resources allocated to us for testing.
       Apache Spark repository finds our workflow, and links it in a comment in our PR
   ```
   
   We can do the same for iceberg, i.e run ci on our fork and iceberg just finds the run and attaches the workflow to our pr in iceberg repo. 
   
   As per spark folks : 
   
   ```
   Spark was one of the projects that uses the GitHub resources most in ASF, and now it's one of the lowest after this change :-).
   ```
   
   Happy to create a pr to do same for iceberg. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org