You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by pt...@apache.org on 2024/10/17 09:02:46 UTC
(ignite-3) branch main updated: IGNITE-23258 Fix testRequestsMetrics flakiness (#4579)
This is an automated email from the ASF dual-hosted git repository.
ptupitsyn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new b3f797e019 IGNITE-23258 Fix testRequestsMetrics flakiness (#4579)
b3f797e019 is described below
commit b3f797e0194a78328e5ecdc71970ff840bc61a47
Author: Pavel Tupitsyn <pt...@apache.org>
AuthorDate: Thu Oct 17 12:02:40 2024 +0300
IGNITE-23258 Fix testRequestsMetrics flakiness (#4579)
Get rid of heartbeats in testRequestsMetrics to ensure consistent request count.
---
.../src/test/java/org/apache/ignite/client/ClientMetricsTest.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/modules/client/src/test/java/org/apache/ignite/client/ClientMetricsTest.java b/modules/client/src/test/java/org/apache/ignite/client/ClientMetricsTest.java
index 869bd5decf..c438f8d53d 100644
--- a/modules/client/src/test/java/org/apache/ignite/client/ClientMetricsTest.java
+++ b/modules/client/src/test/java/org/apache/ignite/client/ClientMetricsTest.java
@@ -166,7 +166,7 @@ public class ClientMetricsTest extends BaseIgniteAbstractTest {
Function<Integer, Boolean> shouldDropConnection = requestIdx -> requestIdx == 5;
Function<Integer, Integer> responseDelay = idx -> idx == 4 ? 1000 : 0;
server = new TestServer(
- 1000,
+ 1_000_000,
new FakeIgnite(),
shouldDropConnection,
responseDelay,
@@ -175,7 +175,9 @@ public class ClientMetricsTest extends BaseIgniteAbstractTest {
null,
null
);
- client = clientBuilder().build();
+ client = clientBuilder()
+ .heartbeatInterval(1_000_000)
+ .build();
assertEquals(0, metrics().requestsActive());
assertEquals(0, metrics().requestsFailed());
@@ -221,7 +223,7 @@ public class ClientMetricsTest extends BaseIgniteAbstractTest {
assertEquals(1, metrics().requestsFailed());
assertEquals(3, metrics().requestsCompleted());
- assertEquals(6, metrics().requestsSent());
+ assertEquals(5, metrics().requestsSent());
assertEquals(1, metrics().requestsRetried());
}