You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/07/01 03:33:26 UTC

[GitHub] [incubator-shenyu-dashboard] 847850277 opened a new pull request, #213: feature: use path to search

847850277 opened a new pull request, #213:
URL: https://github.com/apache/incubator-shenyu-dashboard/pull/213

   Hi community: 
       I have completed the feature use path to search.
       please review the code.
       see issues [use path to search](https://github.com/apache/incubator-shenyu/issues/3631)
   
   
   
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu-dashboard] dragon-zhang commented on a diff in pull request #213: feature: use path to search

Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #213:
URL: https://github.com/apache/incubator-shenyu-dashboard/pull/213#discussion_r912313261


##########
src/routes/System/Metadata/index.js:
##########
@@ -398,9 +399,9 @@ export default class Metadata extends Component {
       <div className="plug-content-wrap">
         <div style={{ display: "flex" }}>
           <Input
-            value={appName}
+            value={path}
             onChange={this.searchOnchange}
-            placeholder={getIntlContent("SHENYU.META.INPUTAPPNAME")}
+            placeholder={getIntlContent("SHENYU.META.PATH")}

Review Comment:
   I mean add `SHENYU.META.INPUTPATH` to `zh-CN.json` and `en-US.json`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu-dashboard] 847850277 commented on a diff in pull request #213: feature: use path to search

Posted by GitBox <gi...@apache.org>.
847850277 commented on code in PR #213:
URL: https://github.com/apache/incubator-shenyu-dashboard/pull/213#discussion_r911826507


##########
src/routes/System/Metadata/index.js:
##########
@@ -398,9 +399,9 @@ export default class Metadata extends Component {
       <div className="plug-content-wrap">
         <div style={{ display: "flex" }}>
           <Input
-            value={appName}
+            value={path}
             onChange={this.searchOnchange}
-            placeholder={getIntlContent("SHENYU.META.INPUTAPPNAME")}
+            placeholder={getIntlContent("SHENYU.META.PATH")}

Review Comment:
   when i use "INPUTPATH", the placeholder has not default value. 
   ![image](https://user-images.githubusercontent.com/12622645/176874581-12091829-7397-46da-bdb3-4ba9be242a12.png)
   
   and i use "PATH",the placeholder has default value. 
   
   ![image](https://user-images.githubusercontent.com/12622645/176874847-24b93c42-0bb7-4390-b3e3-54bde520c25c.png)
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu-dashboard] dragon-zhang merged pull request #213: feature: use path to search

Posted by GitBox <gi...@apache.org>.
dragon-zhang merged PR #213:
URL: https://github.com/apache/incubator-shenyu-dashboard/pull/213


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu-dashboard] dragon-zhang commented on a diff in pull request #213: feature: use path to search

Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #213:
URL: https://github.com/apache/incubator-shenyu-dashboard/pull/213#discussion_r911814405


##########
src/routes/System/Metadata/index.js:
##########
@@ -398,9 +399,9 @@ export default class Metadata extends Component {
       <div className="plug-content-wrap">
         <div style={{ display: "flex" }}>
           <Input
-            value={appName}
+            value={path}
             onChange={this.searchOnchange}
-            placeholder={getIntlContent("SHENYU.META.INPUTAPPNAME")}
+            placeholder={getIntlContent("SHENYU.META.PATH")}

Review Comment:
   add and replace to `placeholder={getIntlContent("SHENYU.META.INPUTPATH")}`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu-dashboard] dragon-zhang commented on pull request #213: feature: use path to search

Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on PR #213:
URL: https://github.com/apache/incubator-shenyu-dashboard/pull/213#issuecomment-1172894090

   @847850277 happy contribution ! please add wechat Z18179469818


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu-dashboard] 847850277 closed pull request #213: feature: use path to search

Posted by GitBox <gi...@apache.org>.
847850277 closed pull request #213: feature: use path to search
URL: https://github.com/apache/incubator-shenyu-dashboard/pull/213


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu-dashboard] dragon-zhang commented on pull request #213: feature: use path to search

Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on PR #213:
URL: https://github.com/apache/incubator-shenyu-dashboard/pull/213#issuecomment-1171106913

   good job, I will check it.
   
   
   
   
   
   
   
   ------------------ Original ------------------
   From: zhengpeng ***@***.***&gt;
   Date: Thu,Jun 30,2022 5:19 PM
   To: apache/incubator-shenyu-dashboard ***@***.***&gt;
   Cc: Subscribed ***@***.***&gt;
   Subject: Re: [apache/incubator-shenyu-dashboard] feature: use path to search (PR #213)
   
   
   
   
   Hi community:
    I have completed the feature use path to search.
    please review the code.
    see issues use path to search
    
    
   You can view, comment on, or merge this pull request online at:
    
   &nbsp; https://github.com/apache/incubator-shenyu-dashboard/pull/213
    
   Commit Summary
       
   007e70f  feature: 
    
   File Changes 
    
   (2 files)
       
        M     src/routes/System/Metadata/index.js     (13)      
   
        M     src/services/api.js     (4)    
    
   Patch Links:
       
   https://github.com/apache/incubator-shenyu-dashboard/pull/213.patch   
   
   https://github.com/apache/incubator-shenyu-dashboard/pull/213.diff 
    
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you are subscribed to this thread.Message ID: ***@***.***&gt;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu-dashboard] 847850277 commented on a diff in pull request #213: feature: use path to search

Posted by GitBox <gi...@apache.org>.
847850277 commented on code in PR #213:
URL: https://github.com/apache/incubator-shenyu-dashboard/pull/213#discussion_r912317216


##########
src/routes/System/Metadata/index.js:
##########
@@ -398,9 +399,9 @@ export default class Metadata extends Component {
       <div className="plug-content-wrap">
         <div style={{ display: "flex" }}>
           <Input
-            value={appName}
+            value={path}
             onChange={this.searchOnchange}
-            placeholder={getIntlContent("SHENYU.META.INPUTAPPNAME")}
+            placeholder={getIntlContent("SHENYU.META.PATH")}

Review Comment:
   Thank you. I see. I have modified this place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org