You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/08/10 11:26:59 UTC
[GitHub] [druid] AmatyaAvadhanula opened a new pull request, #12886: Kinesis docs and logs improvements
AmatyaAvadhanula opened a new pull request, #12886:
URL: https://github.com/apache/druid/pull/12886
https://github.com/apache/druid/pull/12792 allows kinesis ingestion with empty shards and removes the need for a sequence number fetch timeout. This PR fixes the docs to not mention related limitations.
It also improves other kinesis ingestion logs such as `OrderedPartitionableRecord buffer full`
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #12886: Kinesis docs and logs improvements
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on code in PR #12886:
URL: https://github.com/apache/druid/pull/12886#discussion_r943116145
##########
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java:
##########
@@ -228,7 +228,9 @@ private Runnable fetchRecords()
recordsResult = null;
if (!records.offer(currRecord, recordBufferOfferTimeout, TimeUnit.MILLISECONDS)) {
- log.warn("OrderedPartitionableRecord buffer full, retrying in [%,dms]", recordBufferFullWait);
+ log.warn("OrderedPartitionableRecord buffer full, retrying in [%,dms]. "
+ + "Kinesis records are being processed slower than they are fetched.",
+ recordBufferFullWait);
Review Comment:
```suggestion
log.warn("Kinesis records are being processed slower than they are fetched. "
+ "OrderedPartitionableRecord buffer full, retrying in [%,dms].",
recordBufferFullWait);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #12886: Kinesis docs and logs improvements
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on PR #12886:
URL: https://github.com/apache/druid/pull/12886#issuecomment-1211577351
the build has likely failed due to a code coverage check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #12886: Kinesis docs and logs improvements
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 merged PR #12886:
URL: https://github.com/apache/druid/pull/12886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org