You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/06/29 22:36:50 UTC
[GitHub] [trafficserver] bneradt opened a new pull request, #8931: Fix clang-format installation with multiple threads
bneradt opened a new pull request, #8931:
URL: https://github.com/apache/trafficserver/pull/8931
The initial run of the clang-format target with multiple threads would
invoke multiple instances of tools/clang-format.sh at the same time.
This would result in multiple processes trying to install the
clang-format binary into .git/fmt, leading to a failure with a a "Text
file busy" error. Subsequent runs would succeed, however, because the
binary had already been installed.
This updates the tools/clang-format.sh script to take a `--install`
argument which just installs clang-format to .git/fmt, and makes the
existence of that directory a prerequisite for the clang-format target.
If it doesn't exist, then it is created with a run of
`tools/clang-format.sh --install`. Then the various clang-format-<dir>
targets run in parallel without each trying to install the tool.
This also adds, for convenience, a `format` target that runs both
`clang-format` and `autopep8`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8931: Fix clang-format installation with multiple threads
Posted by GitBox <gi...@apache.org>.
zwoop commented on PR #8931:
URL: https://github.com/apache/trafficserver/pull/8931#issuecomment-1176456522
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #8931: Fix clang-format installation with multiple threads
Posted by GitBox <gi...@apache.org>.
bneradt merged PR #8931:
URL: https://github.com/apache/trafficserver/pull/8931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org