You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/01 19:56:07 UTC

[GitHub] [arrow] kou commented on pull request #13282: ARROW-16609: [C++] xxhash not installed into dist/lib/include when building C++

kou commented on PR #13282:
URL: https://github.com/apache/arrow/pull/13282#issuecomment-1144072159

   Renaming `int_util_internal.h` to `int_util_overflow.h` is OK if it only includes overflow related codes but the current `int_util_internal.h` has `UpcastInt()` and `CheckSliceParams()` that aren't related to overflow.
   
   What functions do you want? Can we move only them to `int_util.h` from `int_util_internal.h`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org