[GitHub] [airflow] kaxil commented on a change in pull request #17683: rename none_failed_or_skipped by none_failed_min_one_success

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #17683:
URL: https://github.com/apache/airflow/pull/17683#discussion_r692086228



##########
File path: UPDATING.md
##########
@@ -89,6 +89,11 @@ installing Airflow, example for Python 3.8 and Airflow 2.1.2:
 pip install -U "apache-airflow[pandas]==2.1.2" \
   --constraint https://raw.githubusercontent.com/apache/airflow/constraints-2.1.2/constraints-3.8.txt"
 ```
+### none_failed_or_skipped trigger rule has been deprecated

Review comment:
       ```suggestion
   ### `none_failed_or_skipped` trigger rule has been deprecated
   ```

##########
File path: airflow/models/baseoperator.py
##########
@@ -551,6 +551,15 @@ def __init__(
             )
             trigger_rule = TriggerRule.ALWAYS
 
+        if trigger_rule == "none_failed_or_skipped":
+            warnings.warn(
+                "none_failed_or_skipped Trigger Rule is deprecated. "
+                "Please use `TriggerRule.NONE_FAILED_MIN_ONE_SUCCESS`.",

Review comment:
       ```suggestion
                   "none_failed_or_skipped Trigger Rule is deprecated. "
                   "Please use `none_failed_min_one_success`.",
   ```
   
   or
   
   ```
                   "TriggerRule.NONE_FAILED_OR_SKIPPED Trigger Rule is deprecated. "
                   "Please use `TriggerRule.NONE_FAILED_MIN_ONE_SUCCESS`.",
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org