You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/06/08 06:04:43 UTC

[GitHub] [netbeans] lkishalmi opened a new pull request #2171: Moved Gradle modules out of Groovy cluster

lkishalmi opened a new pull request #2171:
URL: https://github.com/apache/netbeans/pull/2171

This change is about to move Gradle out of Groovy's shade. My motivation are the following:

- Groovy is not really required by Gradle. Having it next to Maven and Ant, would be more suitable.
- C/C++ Support is coming soon. I'd like to add Gradle Native projects to that support.

This change would move Gradle modules out from the Groovy Cluster to:

- ide: libs.gradle (Gradle Tooling library), gradle (Gradle Project support)
- java: gradle,java, gradle.java.coverage, gradle kit, gradle.persistence, gradle.spring and gradle.test (These are the modules that supporting the Java development)
- enterprise: gradle.javaee (Gradle Web Project support)

Please share your wisdom! I might need to recreate this PR as probably some other changes would be better to be included in the repo, so this one is just to have a glimpse.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi merged pull request #2171: Moved Gradle modules out of Groovy cluster

Posted by GitBox <gi...@apache.org>.

lkishalmi merged pull request #2171:
URL: https://github.com/apache/netbeans/pull/2171


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on a change in pull request #2171: Moved Gradle modules out of Groovy cluster

Posted by GitBox <gi...@apache.org>.

lkishalmi commented on a change in pull request #2171:
URL: https://github.com/apache/netbeans/pull/2171#discussion_r438269496



##########
File path: extide/gradle/src/org/netbeans/modules/gradle/layer.xml
##########
@@ -134,12 +134,27 @@
     </folder>
     <folder name="Editors">
         <folder name="text">
-            <!--folder name="x-gradle+x-groovy">
-                <file name="org-netbeans-modules-csl-core-GsfParserFactory-create.instance">
-                    <attr methodvalue="org.netbeans.modules.csl.core.GsfParserFactory.create" name="instanceCreate"/>
-                    <attr name="instanceOf" stringvalue="org.netbeans.modules.parsing.spi.ParserFactory"/>
+            <folder name="x-gradle+x-groovy">

Review comment:
       Can someone check this who is more familiar with MultiView than I am?
   The intention is that gradle scripts are loaded by the plain editor kit if the Groovy support is absent.
   As far as I tested it works. As soon as the Groovy plugins got enabled the editor get syntax highlight, though for "efficient" (Groovy) code completion, the IDE needs to be restarted, but I do not think that an issue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2171: Moved Gradle modules out of Groovy cluster

Posted by GitBox <gi...@apache.org>.

lkishalmi commented on pull request #2171:
URL: https://github.com/apache/netbeans/pull/2171#issuecomment-640750488


   Well, unfortunately the Groovy editor do not offer too much help when editing Gradle files. Also it is not an everyday task for most of the users to edit the build files, mostly just to change/add dependencies and that can be done without Groovy. If someone would enable the Groovy cluster, then it would have more editing options, but that's it.
   
   Thank you for mentioning the extide cluster, yes Gradle could belong there. I just was not aware of the existence of that cluster.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] jlahoda commented on pull request #2171: Moved Gradle modules out of Groovy cluster

Posted by GitBox <gi...@apache.org>.

jlahoda commented on pull request #2171:
URL: https://github.com/apache/netbeans/pull/2171#issuecomment-641523037


   I'd vote for extide cluster over ide cluster for the base Gradle support - AFAIK we don't have build systems in the ide cluster. C/C++ support should be fine with depending on the extide cluster.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on pull request #2171: Moved Gradle modules out of Groovy cluster

Posted by GitBox <gi...@apache.org>.

JaroslavTulach commented on pull request #2171:
URL: https://github.com/apache/netbeans/pull/2171#issuecomment-640717597

Enabling Gradle without enabling support for Groovy in the editor doesn't make much sense to me. While I know that Kotlin guys are trying hard to replace Groovy, 95% project build scripts is still in Groovy, I'd bet.

C/C++ support is likely to end up in a `cnd` cluster. That cluster never had a dependency on `java` cluster. The `cnd` functionality is using Ant (for historical reasons, I'd say) - however to do that the basic Ant support had to be moved to an artificially created `extide` cluster. The logic was that Ant is too Java oriented to belong into generic `ide` cluster (mostly editor, version control, etc.).

Gradle is certainly also "too Java oriented". Maybe it belongs next to Ant into `extide`?

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2171: Moved Gradle modules out of Groovy cluster

Posted by GitBox <gi...@apache.org>.

lkishalmi commented on pull request #2171:
URL: https://github.com/apache/netbeans/pull/2171#issuecomment-643895064


   Works as I've imagined. Made Travis happy too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists