You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/03/20 12:59:32 UTC
Review Request 57776: Hive View2.0: Upload table fails,
if one column is deleted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57776/
-----------------------------------------------------------
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20497
https://issues.apache.org/jira/browse/AMBARI-20497
Repository: ambari
Description
-------
Added a var 'fromUploadTable' as true when it comes from upload table otherwise false.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/components/column-item.js f2e45bd
contrib/views/hive20/src/main/resources/ui/app/components/create-table.js 322aab5
contrib/views/hive20/src/main/resources/ui/app/components/table-columns.js 7d83353
contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js e6b71fe
contrib/views/hive20/src/main/resources/ui/app/templates/components/column-item.hbs 762c77c
contrib/views/hive20/src/main/resources/ui/app/templates/components/create-table.hbs f369783
contrib/views/hive20/src/main/resources/ui/app/templates/components/table-columns.hbs b942136
contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs 0ee6b81
contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/upload-table.hbs 0091ede
Diff: https://reviews.apache.org/r/57776/diff/1/
Testing
-------
manually test.
Thanks,
Pallav Kulshreshtha
Re: Review Request 57776: Hive View2.0: Upload table fails,
if one column is deleted
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57776/#review169455
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On March 20, 2017, 2:12 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57776/
> -----------------------------------------------------------
>
> (Updated March 20, 2017, 2:12 p.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20497
> https://issues.apache.org/jira/browse/AMBARI-20497
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added a var 'fromUploadTable' as true when it comes from upload table otherwise false.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js e6b71fe
> contrib/views/hive20/src/main/resources/ui/app/templates/components/column-item.hbs 762c77c
> contrib/views/hive20/src/main/resources/ui/app/templates/components/create-table.hbs f369783
> contrib/views/hive20/src/main/resources/ui/app/templates/components/table-columns.hbs b942136
> contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs 0ee6b81
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/upload-table.hbs 0091ede
>
>
> Diff: https://reviews.apache.org/r/57776/diff/2/
>
>
> Testing
> -------
>
> manually test.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 57776: Hive View2.0: Upload table fails,
if one column is deleted
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57776/
-----------------------------------------------------------
(Updated March 20, 2017, 2:12 p.m.)
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20497
https://issues.apache.org/jira/browse/AMBARI-20497
Repository: ambari
Description
-------
Added a var 'fromUploadTable' as true when it comes from upload table otherwise false.
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js e6b71fe
contrib/views/hive20/src/main/resources/ui/app/templates/components/column-item.hbs 762c77c
contrib/views/hive20/src/main/resources/ui/app/templates/components/create-table.hbs f369783
contrib/views/hive20/src/main/resources/ui/app/templates/components/table-columns.hbs b942136
contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs 0ee6b81
contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/upload-table.hbs 0091ede
Diff: https://reviews.apache.org/r/57776/diff/2/
Changes: https://reviews.apache.org/r/57776/diff/1-2/
Testing
-------
manually test.
Thanks,
Pallav Kulshreshtha
Re: Review Request 57776: Hive View2.0: Upload table fails,
if one column is deleted
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
> On March 20, 2017, 1:11 p.m., Nitiraj Rathore wrote:
> > contrib/views/hive20/src/main/resources/ui/app/components/column-item.js
> > Line 27 (original), 27 (patched)
> > <https://reviews.apache.org/r/57776/diff/1/?file=1668371#file1668371line27>
> >
> > Make this options object instead.
Niti, uploaded the code with suggested changes.Pls have a look.
- Pallav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57776/#review169432
-----------------------------------------------------------
On March 20, 2017, 2:12 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57776/
> -----------------------------------------------------------
>
> (Updated March 20, 2017, 2:12 p.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20497
> https://issues.apache.org/jira/browse/AMBARI-20497
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added a var 'fromUploadTable' as true when it comes from upload table otherwise false.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js e6b71fe
> contrib/views/hive20/src/main/resources/ui/app/templates/components/column-item.hbs 762c77c
> contrib/views/hive20/src/main/resources/ui/app/templates/components/create-table.hbs f369783
> contrib/views/hive20/src/main/resources/ui/app/templates/components/table-columns.hbs b942136
> contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs 0ee6b81
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/upload-table.hbs 0091ede
>
>
> Diff: https://reviews.apache.org/r/57776/diff/2/
>
>
> Testing
> -------
>
> manually test.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 57776: Hive View2.0: Upload table fails,
if one column is deleted
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57776/#review169432
-----------------------------------------------------------
contrib/views/hive20/src/main/resources/ui/app/components/column-item.js
Line 27 (original), 27 (patched)
<https://reviews.apache.org/r/57776/#comment241776>
Make this options object instead.
- Nitiraj Rathore
On March 20, 2017, 12:59 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57776/
> -----------------------------------------------------------
>
> (Updated March 20, 2017, 12:59 p.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20497
> https://issues.apache.org/jira/browse/AMBARI-20497
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added a var 'fromUploadTable' as true when it comes from upload table otherwise false.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/column-item.js f2e45bd
> contrib/views/hive20/src/main/resources/ui/app/components/create-table.js 322aab5
> contrib/views/hive20/src/main/resources/ui/app/components/table-columns.js 7d83353
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js e6b71fe
> contrib/views/hive20/src/main/resources/ui/app/templates/components/column-item.hbs 762c77c
> contrib/views/hive20/src/main/resources/ui/app/templates/components/create-table.hbs f369783
> contrib/views/hive20/src/main/resources/ui/app/templates/components/table-columns.hbs b942136
> contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs 0ee6b81
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/upload-table.hbs 0091ede
>
>
> Diff: https://reviews.apache.org/r/57776/diff/1/
>
>
> Testing
> -------
>
> manually test.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>