You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2017/07/25 17:02:54 UTC
[kudu-CR] Fix bug kudu-2058
srisaikumarr@gmail.com has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7500
Change subject: Fix bug kudu-2058
......................................................................
Fix bug kudu-2058
Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
---
M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/7500/1
--
To view, visit http://gerrit.cloudera.org:8080/7500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
[kudu-CR] Remove whitespaces
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
srisaikumarr@gmail.com has posted comments on this change.
Change subject: Remove whitespaces
......................................................................
Patch Set 2:
Hi Jean, I changed the title to make it relevant to the purpose. Please let me know if I missed anything. Thanks so much for taking time.
--
To view, visit http://gerrit.cloudera.org:8080/7500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: srisaikumarr@gmail.com
Gerrit-HasComments: No
[kudu-CR] Fix bug kudu-2058
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Fix bug kudu-2058
......................................................................
Patch Set 1:
Hi, just leaving a comment about how we use gerrit, please checkout http://kudu.apache.org/docs/contributing.html#_submitting_patches
In particular, amend your patches and push the amended commits instead of abandoning patches every time you have a new revision. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/7500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Fix bug kudu-2058
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
srisaikumarr@gmail.com has posted comments on this change.
Change subject: Fix bug kudu-2058
......................................................................
Patch Set 1:
Sure Jean, will amend commits from next time.
--
To view, visit http://gerrit.cloudera.org:8080/7500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: srisaikumarr@gmail.com
Gerrit-HasComments: No
[kudu-CR] Remove whitespaces
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7500
to look at the new patch set (#2).
Change subject: Remove whitespaces
......................................................................
Remove whitespaces
Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
---
M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/7500/2
--
To view, visit http://gerrit.cloudera.org:8080/7500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: srisaikumarr@gmail.com
[kudu-CR] KUDU-2058. Fix LocatedTablet string comparisons
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-2058. Fix LocatedTablet string comparisons
......................................................................
KUDU-2058. Fix LocatedTablet string comparisons
Fixed LocatedTablet string comparison with enum comparison.
Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
Reviewed-on: http://gerrit.cloudera.org:8080/7500
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: srisaikumarr@gmail.com
[kudu-CR] KUDU-2058. Fix LocatedTablet string comparisons
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7500
to look at the new patch set (#3).
Change subject: KUDU-2058. Fix LocatedTablet string comparisons
......................................................................
KUDU-2058. Fix LocatedTablet string comparisons
Fixed LocatedTablet string comparison with enum comparison.
Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
---
M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/7500/3
--
To view, visit http://gerrit.cloudera.org:8080/7500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: srisaikumarr@gmail.com
[kudu-CR] Remove whitespaces
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Remove whitespaces
......................................................................
Patch Set 2:
Hi, further feedback on usage, please make sure the title stays relevant when amending. For reviewing purposes we don't use the commit title as a way to describe what changed between revisions. So your title should stay something like "KUDU-2058. Fix LocatedTablet string comparisons" and it should not change unless it starts doing something else.
Also read this for how to write git commit messages: https://chris.beams.io/posts/git-commit/
--
To view, visit http://gerrit.cloudera.org:8080/7500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: srisaikumarr@gmail.com
Gerrit-HasComments: No
[kudu-CR] KUDU-2058. Fix LocatedTablet string comparisons
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-2058. Fix LocatedTablet string comparisons
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1926f84a79fed80ab5e72fa0fbf4aa450906643
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: srisaikumarr@gmail.com
Gerrit-HasComments: No