[GitHub] [druid] abhishekrb19 commented on a change in pull request #10235: Add "offset" parameter to GroupBy query.

[GitBox <gi...@apache.org>]

abhishekrb19 commented on a change in pull request #10235:
URL: https://github.com/apache/druid/pull/10235#discussion_r469416176



##########
File path: processing/src/main/java/org/apache/druid/query/groupby/orderby/DefaultLimitSpec.java
##########
@@ -113,12 +139,32 @@ public DefaultLimitSpec(
     return columns;
   }
 
+  /**
+   * Offset for this query; behaves like SQL "OFFSET". Zero means no offset. Negative values are invalid.
+   */
   @JsonProperty
+  @JsonInclude(JsonInclude.Include.NON_DEFAULT)
+  public int getOffset()
+  {
+    return offset;
+  }
+
+  /**
+   * Offset for this query; behaves like SQL "LIMIT". Will always be positive. {@link Integer#MAX_VALUE} is used in

Review comment:
       Should this perhaps be 'Limit' instead of 'Offset'?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org