You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2019/08/01 08:23:37 UTC

[tomcat] branch 8.5.x updated (545cc20 -> 7cb7569)

This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git.


    from 545cc20  BZ 62496: Add option to write auth information (remote user/auth type) to response headers
     new 3c63d7f  Fix build failure
     new 35939c4  Fix unused code warnings
     new 7cb7569  Fix broken Javadoc

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 java/org/apache/catalina/authenticator/AuthenticatorBase.java      | 3 ++-
 .../apache/catalina/authenticator/TestAuthInfoResponseHeaders.java | 7 ++++---
 2 files changed, 6 insertions(+), 4 deletions(-)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[tomcat] 02/03: Fix unused code warnings

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 35939c495b2b3fa0d48450ba783e119dc9bb2069
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Aug 1 09:03:42 2019 +0100

    Fix unused code warnings
---
 test/org/apache/catalina/authenticator/TestAuthInfoResponseHeaders.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/org/apache/catalina/authenticator/TestAuthInfoResponseHeaders.java b/test/org/apache/catalina/authenticator/TestAuthInfoResponseHeaders.java
index 9c27410..302a140 100644
--- a/test/org/apache/catalina/authenticator/TestAuthInfoResponseHeaders.java
+++ b/test/org/apache/catalina/authenticator/TestAuthInfoResponseHeaders.java
@@ -101,7 +101,7 @@ public class TestAuthInfoResponseHeaders extends TomcatBaseTest {
         Map<String,List<String>> reqHeaders = new HashMap<>();
 
         List<String> auth = new ArrayList<>();
-        auth.add(new BasicCredentials("Basic", USER, PWD).getCredentials());
+        auth.add(new BasicCredentials("Basic", user, pwd).getCredentials());
         reqHeaders.put(CLIENT_AUTH_HEADER, auth);
 
         List<String> forwardedFor = new ArrayList<>();


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[tomcat] 01/03: Fix build failure

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 3c63d7f959caeabf52526e9610b6cbef82d9e0d5
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Aug 1 09:02:00 2019 +0100

    Fix build failure
---
 .../apache/catalina/authenticator/TestAuthInfoResponseHeaders.java   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/test/org/apache/catalina/authenticator/TestAuthInfoResponseHeaders.java b/test/org/apache/catalina/authenticator/TestAuthInfoResponseHeaders.java
index 881c37b..9c27410 100644
--- a/test/org/apache/catalina/authenticator/TestAuthInfoResponseHeaders.java
+++ b/test/org/apache/catalina/authenticator/TestAuthInfoResponseHeaders.java
@@ -24,6 +24,9 @@ import java.util.Map;
 
 import javax.servlet.http.HttpServletRequest;
 
+import org.junit.Assert;
+import org.junit.Test;
+
 import org.apache.catalina.Context;
 import org.apache.catalina.startup.TesterMapRealm;
 import org.apache.catalina.startup.TesterServlet;
@@ -35,8 +38,6 @@ import org.apache.tomcat.util.codec.binary.Base64;
 import org.apache.tomcat.util.descriptor.web.LoginConfig;
 import org.apache.tomcat.util.descriptor.web.SecurityCollection;
 import org.apache.tomcat.util.descriptor.web.SecurityConstraint;
-import org.junit.Assert;
-import org.junit.Test;
 
 public class TestAuthInfoResponseHeaders extends TomcatBaseTest {
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[tomcat] 03/03: Fix broken Javadoc

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 7cb7569e35723f64fb66ea9200b534f8f8a15355
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Aug 1 09:04:48 2019 +0100

    Fix broken Javadoc
---
 java/org/apache/catalina/authenticator/AuthenticatorBase.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/catalina/authenticator/AuthenticatorBase.java b/java/org/apache/catalina/authenticator/AuthenticatorBase.java
index c8b8b87..dad6783 100644
--- a/java/org/apache/catalina/authenticator/AuthenticatorBase.java
+++ b/java/org/apache/catalina/authenticator/AuthenticatorBase.java
@@ -460,7 +460,8 @@ public abstract class AuthenticatorBase extends ValveBase
      * Sets the flag whether authentication information will be send to a reverse
      * proxy on a forwarded request.
      *
-     * @param {@code true} if response headers shall be sent, {@code false} otherwise
+     * @param sendAuthInfoResponseHeaders {@code true} if response headers shall be
+     *                                    sent, {@code false} otherwise
      */
     public void setSendAuthInfoResponseHeaders(boolean sendAuthInfoResponseHeaders) {
         this.sendAuthInfoResponseHeaders = sendAuthInfoResponseHeaders;


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org