[GitHub] [iceberg] singhpk234 commented on a diff in pull request #5860: Spark: Fix QueryFailure when running RewriteManifestProcedure on Date partitioned table

[GitBox <gi...@apache.org>]

singhpk234 commented on code in PR #5860:
URL: https://github.com/apache/iceberg/pull/5860#discussion_r997766181


##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteManifestsProcedure.java:
##########
@@ -75,6 +96,79 @@ public void testRewriteLargeManifests() {
         "Must have 4 manifests", 4, table.currentSnapshot().allManifests(table.io()).size());
   }
 
+  @Test
+  public void testRewriteLargeManifestsWithDateOrTimestampPartitionedTables() {
+    String[] scenarios = new String[] {"true", "false"};
+    String[] partitionColTypes = new String[] {"DATE", "TIMESTAMP"};

Review Comment:
   > That's the normal case that we know works, right? I guess it's good to have for completeness?
   
   +1, the normal case works, added the normal case for increasing the coverage and completeness as we didn't had UT's for date / timestamp partitioned tables before. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org