You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/17 22:39:14 UTC
[GitHub] [airflow] jedcunningham opened a new pull request #19663: Update Airflow release guide
jedcunningham opened a new pull request #19663:
URL: https://github.com/apache/airflow/pull/19663
Just more changes for the guide after releasing 2.2.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #19663: Update Airflow release guide
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #19663:
URL: https://github.com/apache/airflow/pull/19663#discussion_r751707322
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -757,16 +783,17 @@ previously released RC candidates in "${AIRFLOW_SOURCES}/dist":
- Upload the package to PyPI's production environment:
```shell script
- twine upload -r pypi dist/*
+ twine upload -r pypi *.whl *${VERSION}.tar.gz
Review comment:
Haha yeah, my fear of that was the driver to upload from svn instead 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #19663: Update Airflow release guide
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #19663:
URL: https://github.com/apache/airflow/pull/19663#discussion_r751702843
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -757,16 +783,17 @@ previously released RC candidates in "${AIRFLOW_SOURCES}/dist":
- Upload the package to PyPI's production environment:
```shell script
- twine upload -r pypi dist/*
+ twine upload -r pypi *.whl *${VERSION}.tar.gz
Review comment:
It'd have to be this:
```suggestion
twine upload -r pypi *${VERSION}-py3-none-any.whl *${VERSION}.tar.gz
```
At that point, might even be worth removing globbing:
```suggestion
twine upload -r pypi apache_airflow-${VERSION}-py3-none-any.whl apache-airflow-${VERSION}.tar.gz
```
No strong preference tbh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19663: Update Airflow release guide
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19663:
URL: https://github.com/apache/airflow/pull/19663#discussion_r751706664
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -757,16 +783,17 @@ previously released RC candidates in "${AIRFLOW_SOURCES}/dist":
- Upload the package to PyPI's production environment:
```shell script
- twine upload -r pypi dist/*
+ twine upload -r pypi *.whl *${VERSION}.tar.gz
Review comment:
It once happened with me that I had elasticsearch provider under dist dir while doing twine upload.. My scars from having burnt from there just got better of me 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19663: Update Airflow release guide
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19663:
URL: https://github.com/apache/airflow/pull/19663#discussion_r751699345
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -757,16 +783,17 @@ previously released RC candidates in "${AIRFLOW_SOURCES}/dist":
- Upload the package to PyPI's production environment:
```shell script
- twine upload -r pypi dist/*
+ twine upload -r pypi *.whl *${VERSION}.tar.gz
Review comment:
```suggestion
twine upload -r pypi *${VERSION}*.whl *${VERSION}.tar.gz
```
To be safe, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19663: Update Airflow release guide
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19663:
URL: https://github.com/apache/airflow/pull/19663#issuecomment-972195116
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19663: Update Airflow release guide
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19663:
URL: https://github.com/apache/airflow/pull/19663#discussion_r751699345
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -757,16 +783,17 @@ previously released RC candidates in "${AIRFLOW_SOURCES}/dist":
- Upload the package to PyPI's production environment:
```shell script
- twine upload -r pypi dist/*
+ twine upload -r pypi *.whl *${VERSION}.tar.gz
Review comment:
```suggestion
twine upload -r pypi *${VERSION}*.whl *${VERSION}.tar.gz
```
To be safe in case we have more files, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19663: Update Airflow release guide
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19663:
URL: https://github.com/apache/airflow/pull/19663#discussion_r751702286
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -757,16 +783,17 @@ previously released RC candidates in "${AIRFLOW_SOURCES}/dist":
- Upload the package to PyPI's production environment:
```shell script
- twine upload -r pypi dist/*
+ twine upload -r pypi *.whl *${VERSION}.tar.gz
Review comment:
It's in ${VERSION} dir already. We should not have more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #19663: Update Airflow release guide
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #19663:
URL: https://github.com/apache/airflow/pull/19663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19663: Update Airflow release guide
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19663:
URL: https://github.com/apache/airflow/pull/19663#discussion_r751706664
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -757,16 +783,17 @@ previously released RC candidates in "${AIRFLOW_SOURCES}/dist":
- Upload the package to PyPI's production environment:
```shell script
- twine upload -r pypi dist/*
+ twine upload -r pypi *.whl *${VERSION}.tar.gz
Review comment:
It once happened with me that I had elasticsearch provider under dist dir.. My scars from having burnt from there just got better of me 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19663: Update Airflow release guide
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19663:
URL: https://github.com/apache/airflow/pull/19663#discussion_r751706032
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -757,16 +783,17 @@ previously released RC candidates in "${AIRFLOW_SOURCES}/dist":
- Upload the package to PyPI's production environment:
```shell script
- twine upload -r pypi dist/*
+ twine upload -r pypi *.whl *${VERSION}.tar.gz
Review comment:
Oh yeah, Jarek is right..
The older code, pushed it from dist/ dir... This is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org