You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2021/03/03 16:58:09 UTC

[camel-kafka-connector] 06/07: Replace the sleep w/ the reusable test utilities for waiting for the port to be open

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch camel-master
in repository https://gitbox.apache.org/repos/asf/camel-kafka-connector.git

commit f8df2de57c1b39a704c4f4ece8705dc028ab6266
Author: Otavio Rodolfo Piske <op...@redhat.com>
AuthorDate: Wed Mar 3 15:25:33 2021 +0100

    Replace the sleep w/ the reusable test utilities for waiting for the port to be open
---
 .../kafkaconnector/netty/source/CamelSourceNettyITCase.java  | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/tests/itests-netty/src/test/java/org/apache/camel/kafkaconnector/netty/source/CamelSourceNettyITCase.java b/tests/itests-netty/src/test/java/org/apache/camel/kafkaconnector/netty/source/CamelSourceNettyITCase.java
index b2ef5ee..2d76e27 100644
--- a/tests/itests-netty/src/test/java/org/apache/camel/kafkaconnector/netty/source/CamelSourceNettyITCase.java
+++ b/tests/itests-netty/src/test/java/org/apache/camel/kafkaconnector/netty/source/CamelSourceNettyITCase.java
@@ -24,6 +24,7 @@ import java.util.concurrent.ExecutionException;
 import org.apache.camel.kafkaconnector.common.test.CamelSourceTestSupport;
 import org.apache.camel.kafkaconnector.common.test.TestMessageConsumer;
 import org.apache.camel.kafkaconnector.common.utils.NetworkUtils;
+import org.apache.camel.kafkaconnector.common.utils.TestUtils;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Timeout;
@@ -49,11 +50,8 @@ public class CamelSourceNettyITCase extends CamelSourceTestSupport {
 
     @Override
     protected void produceTestData() {
-        try {
-            // TODO necessary to wait for ckc netty endpoint to be up and ready
-            Thread.sleep(3000);
-        } catch (Exception ignored) {
-        }
+        TestUtils.waitFor(() -> NetworkUtils.portIsOpen(NetworkUtils.getHostname(), port));
+
         sendMessage();
     }
 
@@ -76,7 +74,7 @@ public class CamelSourceNettyITCase extends CamelSourceTestSupport {
     }
 
     @Test
-    @Timeout(30)
+    @Timeout(35)
     public void testLaunchConnector() throws ExecutionException, InterruptedException {
         CamelNettyPropertyFactory connectorPropertyFactory = CamelNettyPropertyFactory
                 .basic()
@@ -92,7 +90,7 @@ public class CamelSourceNettyITCase extends CamelSourceTestSupport {
     }
 
     @Test
-    @Timeout(30)
+    @Timeout(35)
     public void testLaunchConnectorUsingUrl() throws ExecutionException, InterruptedException {
         CamelNettyPropertyFactory connectorPropertyFactory = CamelNettyPropertyFactory
                 .basic()