You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/06 23:31:50 UTC

[GitHub] [beam] ihji commented on a change in pull request #12223: [Beam-4379] Make ParquetIO read splittable

ihji commented on a change in pull request #12223:
URL: https://github.com/apache/beam/pull/12223#discussion_r466739699



##########
File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -154,10 +187,15 @@ public static ReadFiles readFiles(Schema schema) {
 
     abstract @Nullable GenericData getAvroDataModel();
 
+    abstract boolean getSplit();

Review comment:
       +1
   
   also `setSplittable` instead of `setSplit`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org