You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Andrea Cosentino <an...@gmail.com> on 2022/09/14 10:08:37 UTC

Re: [camel] branch main updated: Remove redundant vertx-web-client-version property as it was only required to work around an issue in Vert.x 4.3.2

I think this needs to be backported to 3.18.x too. This was creating
problems in camel k runtime testing while trying to align to 3.18.1 and
camel quarkus related release. So I suppose we'll have problem with 3.18.2
too and CQ release

Il mer 14 set 2022, 11:58 <ja...@apache.org> ha scritto:

> This is an automated email from the ASF dual-hosted git repository.
>
> jamesnetherton pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/camel.git
>
>
> The following commit(s) were added to refs/heads/main by this push:
>      new 89554d78552 Remove redundant vertx-web-client-version property as
> it was only required to work around an issue in Vert.x 4.3.2
> 89554d78552 is described below
>
> commit 89554d7855279b2fa515114e96b8f3a07785b047
> Author: James Netherton <ja...@gmail.com>
> AuthorDate: Wed Sep 14 10:57:15 2022 +0100
>
>     Remove redundant vertx-web-client-version property as it was only
> required to work around an issue in Vert.x 4.3.2
> ---
>  camel-dependencies/pom.xml                          | 1 -
>  components/camel-knative/camel-knative-http/pom.xml | 2 +-
>  components/camel-vertx/camel-vertx-http/pom.xml     | 2 +-
>  parent/pom.xml                                      | 1 -
>  4 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/camel-dependencies/pom.xml b/camel-dependencies/pom.xml
> index fc66d83ee2a..50b663a6cb8 100644
> --- a/camel-dependencies/pom.xml
> +++ b/camel-dependencies/pom.xml
> @@ -532,7 +532,6 @@
>      <velocity-tools-version>3.1</velocity-tools-version>
>      <velocity-version>2.3</velocity-version>
>      <vertx-version>4.3.3</vertx-version>
> -    <vertx-web-client-version>4.3.3</vertx-web-client-version>
>      <vysper-version>0.7</vysper-version>
>      <web3j-quorum-version>0.8.0</web3j-quorum-version>
>      <web3j-version>3.6.0</web3j-version>
> diff --git a/components/camel-knative/camel-knative-http/pom.xml
> b/components/camel-knative/camel-knative-http/pom.xml
> index ec5c2ea3975..7d83a7e2bec 100644
> --- a/components/camel-knative/camel-knative-http/pom.xml
> +++ b/components/camel-knative/camel-knative-http/pom.xml
> @@ -50,7 +50,7 @@
>          <dependency>
>              <groupId>io.vertx</groupId>
>              <artifactId>vertx-web-client</artifactId>
> -            <version>${vertx-web-client-version}</version>
> +            <version>${vertx-version}</version>
>          </dependency>
>          <dependency>
>              <groupId>io.vertx</groupId>
> diff --git a/components/camel-vertx/camel-vertx-http/pom.xml
> b/components/camel-vertx/camel-vertx-http/pom.xml
> index 7e2983df2e1..983ca276f13 100644
> --- a/components/camel-vertx/camel-vertx-http/pom.xml
> +++ b/components/camel-vertx/camel-vertx-http/pom.xml
> @@ -46,7 +46,7 @@
>          <dependency>
>              <groupId>io.vertx</groupId>
>              <artifactId>vertx-web-client</artifactId>
> -            <version>${vertx-web-client-version}</version>
> +            <version>${vertx-version}</version>
>          </dependency>
>
>          <!-- testing -->
> diff --git a/parent/pom.xml b/parent/pom.xml
> index bb577ff5de8..3f8ddee5c16 100644
> --- a/parent/pom.xml
> +++ b/parent/pom.xml
> @@ -519,7 +519,6 @@
>          <velocity-tools-version>3.1</velocity-tools-version>
>          <velocity-version>2.3</velocity-version>
>          <vertx-version>4.3.3</vertx-version>
> -        <vertx-web-client-version>4.3.3</vertx-web-client-version>
>          <vysper-version>0.7</vysper-version>
>          <web3j-version>3.6.0</web3j-version>
>          <web3j-quorum-version>0.8.0</web3j-quorum-version>
>
>

Re: [camel] branch main updated: Remove redundant vertx-web-client-version property as it was only required to work around an issue in Vert.x 4.3.2

Posted by Andrea Cosentino <an...@gmail.com>.
Thank you

Il giorno gio 15 set 2022 alle ore 08:15 James Netherton <
jamesnetherton@gmail.com> ha scritto:

> Backported to 3.18.x here:
>
>
> https://github.com/apache/camel/commit/30cc0500a169f8ef3fdbf81e8c4c67e908fa2b2f
>
> --
> James
>
> On Wed, 14 Sept 2022 at 11:09, Andrea Cosentino <an...@gmail.com> wrote:
>
> > I think this needs to be backported to 3.18.x too. This was creating
> > problems in camel k runtime testing while trying to align to 3.18.1 and
> > camel quarkus related release. So I suppose we'll have problem with
> 3.18.2
> > too and CQ release
> >
> > Il mer 14 set 2022, 11:58 <ja...@apache.org> ha scritto:
> >
> > > This is an automated email from the ASF dual-hosted git repository.
> > >
> > > jamesnetherton pushed a commit to branch main
> > > in repository https://gitbox.apache.org/repos/asf/camel.git
> > >
> > >
> > > The following commit(s) were added to refs/heads/main by this push:
> > >      new 89554d78552 Remove redundant vertx-web-client-version property
> > as
> > > it was only required to work around an issue in Vert.x 4.3.2
> > > 89554d78552 is described below
> > >
> > > commit 89554d7855279b2fa515114e96b8f3a07785b047
> > > Author: James Netherton <ja...@gmail.com>
> > > AuthorDate: Wed Sep 14 10:57:15 2022 +0100
> > >
> > >     Remove redundant vertx-web-client-version property as it was only
> > > required to work around an issue in Vert.x 4.3.2
> > > ---
> > >  camel-dependencies/pom.xml                          | 1 -
> > >  components/camel-knative/camel-knative-http/pom.xml | 2 +-
> > >  components/camel-vertx/camel-vertx-http/pom.xml     | 2 +-
> > >  parent/pom.xml                                      | 1 -
> > >  4 files changed, 2 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/camel-dependencies/pom.xml b/camel-dependencies/pom.xml
> > > index fc66d83ee2a..50b663a6cb8 100644
> > > --- a/camel-dependencies/pom.xml
> > > +++ b/camel-dependencies/pom.xml
> > > @@ -532,7 +532,6 @@
> > >      <velocity-tools-version>3.1</velocity-tools-version>
> > >      <velocity-version>2.3</velocity-version>
> > >      <vertx-version>4.3.3</vertx-version>
> > > -    <vertx-web-client-version>4.3.3</vertx-web-client-version>
> > >      <vysper-version>0.7</vysper-version>
> > >      <web3j-quorum-version>0.8.0</web3j-quorum-version>
> > >      <web3j-version>3.6.0</web3j-version>
> > > diff --git a/components/camel-knative/camel-knative-http/pom.xml
> > > b/components/camel-knative/camel-knative-http/pom.xml
> > > index ec5c2ea3975..7d83a7e2bec 100644
> > > --- a/components/camel-knative/camel-knative-http/pom.xml
> > > +++ b/components/camel-knative/camel-knative-http/pom.xml
> > > @@ -50,7 +50,7 @@
> > >          <dependency>
> > >              <groupId>io.vertx</groupId>
> > >              <artifactId>vertx-web-client</artifactId>
> > > -            <version>${vertx-web-client-version}</version>
> > > +            <version>${vertx-version}</version>
> > >          </dependency>
> > >          <dependency>
> > >              <groupId>io.vertx</groupId>
> > > diff --git a/components/camel-vertx/camel-vertx-http/pom.xml
> > > b/components/camel-vertx/camel-vertx-http/pom.xml
> > > index 7e2983df2e1..983ca276f13 100644
> > > --- a/components/camel-vertx/camel-vertx-http/pom.xml
> > > +++ b/components/camel-vertx/camel-vertx-http/pom.xml
> > > @@ -46,7 +46,7 @@
> > >          <dependency>
> > >              <groupId>io.vertx</groupId>
> > >              <artifactId>vertx-web-client</artifactId>
> > > -            <version>${vertx-web-client-version}</version>
> > > +            <version>${vertx-version}</version>
> > >          </dependency>
> > >
> > >          <!-- testing -->
> > > diff --git a/parent/pom.xml b/parent/pom.xml
> > > index bb577ff5de8..3f8ddee5c16 100644
> > > --- a/parent/pom.xml
> > > +++ b/parent/pom.xml
> > > @@ -519,7 +519,6 @@
> > >          <velocity-tools-version>3.1</velocity-tools-version>
> > >          <velocity-version>2.3</velocity-version>
> > >          <vertx-version>4.3.3</vertx-version>
> > > -        <vertx-web-client-version>4.3.3</vertx-web-client-version>
> > >          <vysper-version>0.7</vysper-version>
> > >          <web3j-version>3.6.0</web3j-version>
> > >          <web3j-quorum-version>0.8.0</web3j-quorum-version>
> > >
> > >
> >
>

Re: [camel] branch main updated: Remove redundant vertx-web-client-version property as it was only required to work around an issue in Vert.x 4.3.2

Posted by James Netherton <ja...@gmail.com>.
Backported to 3.18.x here:

https://github.com/apache/camel/commit/30cc0500a169f8ef3fdbf81e8c4c67e908fa2b2f

--
James

On Wed, 14 Sept 2022 at 11:09, Andrea Cosentino <an...@gmail.com> wrote:

> I think this needs to be backported to 3.18.x too. This was creating
> problems in camel k runtime testing while trying to align to 3.18.1 and
> camel quarkus related release. So I suppose we'll have problem with 3.18.2
> too and CQ release
>
> Il mer 14 set 2022, 11:58 <ja...@apache.org> ha scritto:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > jamesnetherton pushed a commit to branch main
> > in repository https://gitbox.apache.org/repos/asf/camel.git
> >
> >
> > The following commit(s) were added to refs/heads/main by this push:
> >      new 89554d78552 Remove redundant vertx-web-client-version property
> as
> > it was only required to work around an issue in Vert.x 4.3.2
> > 89554d78552 is described below
> >
> > commit 89554d7855279b2fa515114e96b8f3a07785b047
> > Author: James Netherton <ja...@gmail.com>
> > AuthorDate: Wed Sep 14 10:57:15 2022 +0100
> >
> >     Remove redundant vertx-web-client-version property as it was only
> > required to work around an issue in Vert.x 4.3.2
> > ---
> >  camel-dependencies/pom.xml                          | 1 -
> >  components/camel-knative/camel-knative-http/pom.xml | 2 +-
> >  components/camel-vertx/camel-vertx-http/pom.xml     | 2 +-
> >  parent/pom.xml                                      | 1 -
> >  4 files changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/camel-dependencies/pom.xml b/camel-dependencies/pom.xml
> > index fc66d83ee2a..50b663a6cb8 100644
> > --- a/camel-dependencies/pom.xml
> > +++ b/camel-dependencies/pom.xml
> > @@ -532,7 +532,6 @@
> >      <velocity-tools-version>3.1</velocity-tools-version>
> >      <velocity-version>2.3</velocity-version>
> >      <vertx-version>4.3.3</vertx-version>
> > -    <vertx-web-client-version>4.3.3</vertx-web-client-version>
> >      <vysper-version>0.7</vysper-version>
> >      <web3j-quorum-version>0.8.0</web3j-quorum-version>
> >      <web3j-version>3.6.0</web3j-version>
> > diff --git a/components/camel-knative/camel-knative-http/pom.xml
> > b/components/camel-knative/camel-knative-http/pom.xml
> > index ec5c2ea3975..7d83a7e2bec 100644
> > --- a/components/camel-knative/camel-knative-http/pom.xml
> > +++ b/components/camel-knative/camel-knative-http/pom.xml
> > @@ -50,7 +50,7 @@
> >          <dependency>
> >              <groupId>io.vertx</groupId>
> >              <artifactId>vertx-web-client</artifactId>
> > -            <version>${vertx-web-client-version}</version>
> > +            <version>${vertx-version}</version>
> >          </dependency>
> >          <dependency>
> >              <groupId>io.vertx</groupId>
> > diff --git a/components/camel-vertx/camel-vertx-http/pom.xml
> > b/components/camel-vertx/camel-vertx-http/pom.xml
> > index 7e2983df2e1..983ca276f13 100644
> > --- a/components/camel-vertx/camel-vertx-http/pom.xml
> > +++ b/components/camel-vertx/camel-vertx-http/pom.xml
> > @@ -46,7 +46,7 @@
> >          <dependency>
> >              <groupId>io.vertx</groupId>
> >              <artifactId>vertx-web-client</artifactId>
> > -            <version>${vertx-web-client-version}</version>
> > +            <version>${vertx-version}</version>
> >          </dependency>
> >
> >          <!-- testing -->
> > diff --git a/parent/pom.xml b/parent/pom.xml
> > index bb577ff5de8..3f8ddee5c16 100644
> > --- a/parent/pom.xml
> > +++ b/parent/pom.xml
> > @@ -519,7 +519,6 @@
> >          <velocity-tools-version>3.1</velocity-tools-version>
> >          <velocity-version>2.3</velocity-version>
> >          <vertx-version>4.3.3</vertx-version>
> > -        <vertx-web-client-version>4.3.3</vertx-web-client-version>
> >          <vysper-version>0.7</vysper-version>
> >          <web3j-version>3.6.0</web3j-version>
> >          <web3j-quorum-version>0.8.0</web3j-quorum-version>
> >
> >
>