You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by pa...@apache.org on 2016/03/03 21:08:12 UTC

[3/3] groovy git commit: make javadoc assertion tests more visible by directly running JavadocAssertionTestSuite rather than running it via a TestRunner

make javadoc assertion tests more visible by directly running JavadocAssertionTestSuite rather than running it via a TestRunner


Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/34245175
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/34245175
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/34245175

Branch: refs/heads/GROOVY_2_4_X
Commit: 342451759a1afe034cae6931d218c6ca57788048
Parents: 84e8667
Author: pascalschumacher <pa...@gmx.net>
Authored: Thu Mar 3 20:33:18 2016 +0100
Committer: pascalschumacher <pa...@gmx.net>
Committed: Thu Mar 3 20:59:35 2016 +0100

----------------------------------------------------------------------
 src/test/MainJavadocAssertionTest.groovy                 |  4 ++--
 .../groovy/groovy/json/JsonJavadocAssertionTest.groovy   | 11 +++++------
 2 files changed, 7 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/groovy/blob/34245175/src/test/MainJavadocAssertionTest.groovy
----------------------------------------------------------------------
diff --git a/src/test/MainJavadocAssertionTest.groovy b/src/test/MainJavadocAssertionTest.groovy
index 7405ff8..7ff8712 100644
--- a/src/test/MainJavadocAssertionTest.groovy
+++ b/src/test/MainJavadocAssertionTest.groovy
@@ -20,7 +20,7 @@
 import org.junit.runners.Suite
 import org.junit.runner.RunWith
 
-@RunWith(Suite.class)
-@Suite.SuiteClasses(JavadocAssertionTestSuite.class)
+@RunWith(Suite)
+@Suite.SuiteClasses(JavadocAssertionTestSuite)
 class MainJavadocAssertionTest {
 }

http://git-wip-us.apache.org/repos/asf/groovy/blob/34245175/subprojects/groovy-json/src/test/groovy/groovy/json/JsonJavadocAssertionTest.groovy
----------------------------------------------------------------------
diff --git a/subprojects/groovy-json/src/test/groovy/groovy/json/JsonJavadocAssertionTest.groovy b/subprojects/groovy-json/src/test/groovy/groovy/json/JsonJavadocAssertionTest.groovy
index bf974a4..e1ff1a8 100644
--- a/subprojects/groovy-json/src/test/groovy/groovy/json/JsonJavadocAssertionTest.groovy
+++ b/subprojects/groovy-json/src/test/groovy/groovy/json/JsonJavadocAssertionTest.groovy
@@ -18,11 +18,10 @@
  */
 package groovy.json
 
-import junit.textui.TestRunner
+import org.junit.runners.Suite
+import org.junit.runner.RunWith
 
-class JsonJavadocAssertionTest extends GroovyTestCase {
-    // TODO simplify by having suite directly included rather than via TestRunner
-    void testGroovyDoc() {
-        assert TestRunner.run(JavadocAssertionTestSuite.suite()).wasSuccessful()
-    }
+@RunWith(Suite)
+@Suite.SuiteClasses(JavadocAssertionTestSuite)
+class JsonJavadocAssertionTest {
 }