You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/03/28 05:55:35 UTC
Review Request 32598: DRILL-2579: pt 2. Hygiene: Renamed to match
semantics; fixed, added, formatted doc.; basic whitespace.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32598/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Repository: drill-git
Description
-------
- Renamed createConnection -> getConnection (since isn't necessarily a new connection).
- Renamed close -> closeConnections (since not closing the factory but its connections).
- Added documentation fixes, clarifications, formatting.
- Fixed some basic whitespace.
Diffs
-----
exec/jdbc/src/test/java/org/apache/drill/jdbc/CachingConnectionFactory.java df64366
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionFactory.java 8491436
exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 6d8d8e9
exec/jdbc/src/test/java/org/apache/drill/jdbc/MultiConnectionCachingFactory.java 189942d
exec/jdbc/src/test/java/org/apache/drill/jdbc/NonClosableConnection.java 1e37700
exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java 88fb4c6
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java f7ecf0a
Diff: https://reviews.apache.org/r/32598/diff/
Testing
-------
Ran existing tests.
Thanks,
Daniel Barclay
Re: Review Request 32598: DRILL-2579: pt 2. Hygiene: Renamed to match
semantics; fixed, added, formatted doc.; basic whitespace.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32598/#review78728
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On March 31, 2015, 9:33 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32598/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 9:33 p.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2579
> https://issues.apache.org/jira/browse/DRILL-2579
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> - Renamed createConnection -> getConnection (since isn't necessarily a new connection).
> - Renamed close -> closeConnections (since not closing the factory but its connections).
> - Added documentation fixes, clarifications, formatting.
> - Fixed some basic whitespace.
>
>
> Diffs
> -----
>
> exec/jdbc/src/test/java/org/apache/drill/jdbc/CachingConnectionFactory.java df64366
> exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionFactory.java 8491436
> exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 6d8d8e9
> exec/jdbc/src/test/java/org/apache/drill/jdbc/MultiConnectionCachingFactory.java 189942d
> exec/jdbc/src/test/java/org/apache/drill/jdbc/NonClosableConnection.java 1e37700
> exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java 88fb4c6
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java f7ecf0a
>
> Diff: https://reviews.apache.org/r/32598/diff/
>
>
> Testing
> -------
>
> Ran existing tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 32598: DRILL-2579: pt 2. Hygiene: Renamed to match
semantics; fixed, added, formatted doc.; basic whitespace.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32598/
-----------------------------------------------------------
(Updated March 31, 2015, 9:33 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2579
https://issues.apache.org/jira/browse/DRILL-2579
Repository: drill-git
Description
-------
- Renamed createConnection -> getConnection (since isn't necessarily a new connection).
- Renamed close -> closeConnections (since not closing the factory but its connections).
- Added documentation fixes, clarifications, formatting.
- Fixed some basic whitespace.
Diffs
-----
exec/jdbc/src/test/java/org/apache/drill/jdbc/CachingConnectionFactory.java df64366
exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionFactory.java 8491436
exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 6d8d8e9
exec/jdbc/src/test/java/org/apache/drill/jdbc/MultiConnectionCachingFactory.java 189942d
exec/jdbc/src/test/java/org/apache/drill/jdbc/NonClosableConnection.java 1e37700
exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java 88fb4c6
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java f7ecf0a
Diff: https://reviews.apache.org/r/32598/diff/
Testing
-------
Ran existing tests.
Thanks,
Daniel Barclay