You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by igormartsekha <gi...@git.apache.org> on 2017/07/12 10:27:46 UTC

[GitHub] cordova-ios pull request #326: CB-12940: [IOS] Use deployment-target from co...

GitHub user igormartsekha opened a pull request:

    https://github.com/apache/cordova-ios/pull/326

    CB-12940: [IOS] Use deployment-target from config.xml for platform ve…

    …rsion in Podfile
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    IOS
    
    ### What does this PR do?
    It's generate Podfile using `deployment-target` option from config.xml
    
    ### What testing has been done on this change?
    I runed test but it failed, because API.js need valid path to config.xml file. So I changed test, and set up valid path.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/igormartsekha/cordova-ios master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/326.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #326
    
----
commit 2997480a21f82198232dfa061f9a42c186996ed2
Author: Igor Martsekha <ig...@gmail.com>
Date:   2017-07-12T10:11:57Z

    CB-12940: [IOS] Use deployment-target from config.xml for platform version in Podfile

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-ios issue #326: CB-12940: [IOS] Use deployment-target from config.xm...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:

    https://github.com/apache/cordova-ios/pull/326
  
    Not sure yet why the appveyor CI  (Windows) is failing some tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-ios issue #326: CB-12940: [IOS] Use deployment-target from config.xm...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:

    https://github.com/apache/cordova-ios/pull/326
  
    We had to pull in new code for the new linter using eslint. Consequently, some files have changed. Can you try rebasing, then running npm run eslint to make sure it's all kosher


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org