You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/05/20 05:13:25 UTC
[jira] [Commented] (THRIFT-1957) NodeJS TFramedTransport and
TBufferedTransport read bytes as unsigned
[ https://issues.apache.org/jira/browse/THRIFT-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661734#comment-13661734 ]
Hudson commented on THRIFT-1957:
--------------------------------
Integrated in Thrift #646 (See [https://builds.apache.org/job/Thrift/646/])
THRIFT-1957 NodeJS TFramedTransport and TBufferedTransport read bytes as unsigned (Revision f680e95f19f54fa287c56668d215448489352921)
THRIFT-1957 NodeJS TFramedTransport and TBufferedTransport read bytes as unsigned (Revision 99be0275e128d2ec239cc43d96280d1fdf0cd816)
Result = SUCCESS
henrique :
Files :
* lib/nodejs/test/binary.test.js
* lib/nodejs/lib/thrift/binary.js
* test/nodejs/client.js
* test/nodejs/Makefile.am
* lib/nodejs/lib/thrift/transport.js
henrique :
Files :
* lib/nodejs/test/binary.test.js
* lib/nodejs/lib/thrift/transport.js
* test/nodejs/Makefile.am
* lib/nodejs/lib/thrift/binary.js
* test/nodejs/client.js
> NodeJS TFramedTransport and TBufferedTransport read bytes as unsigned
> ---------------------------------------------------------------------
>
> Key: THRIFT-1957
> URL: https://issues.apache.org/jira/browse/THRIFT-1957
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.9
> Environment: NodeJS 10.4, Thrift 0.9
> Reporter: Matthew Imrie
> Assignee: Henrique Mendonça
> Labels: patch
> Fix For: 1.0
>
> Attachments: nodejs-thrift-signed-byte-fix.patch
>
>
> Thrift for NodeJS is reading bytes as unsigned. The Apache Thrift specification describes them as signed.
> I changed the readByte function in both TFramedTransport and TBufferedTransport to call a new readByte method in binary.js that properly converts to a signed byte. Unit test for the method is included in binary.test.js
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira