You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2025/09/11 22:26:00 UTC
[jira] [Work logged] (ARTEMIS-4924) Handle invalid messages in SNF queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4924?focusedWorklogId=982845&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-982845 ]
ASF GitHub Bot logged work on ARTEMIS-4924:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/25 22:25
Start Date: 11/Sep/25 22:25
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5921:
URL: https://github.com/apache/activemq-artemis/pull/5921#discussion_r2342465583
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java:
##########
@@ -630,7 +630,17 @@ public HandleStatus handle(final MessageReference ref) throws Exception {
dest = ref.getMessage().getAddressSimpleString();
}
- final Message message = beforeForward(ref.getMessage(), dest);
+ final Message message;
+ try {
+ message = beforeForward(ref.getMessage(), dest);
+ } catch (ActiveMQException ex) {
+ ActiveMQServerLogger.LOGGER.bridgeUnableToHandleMessage(getName(), ref.getMessage().toString(), ex.getMessage());
+ ref.getQueue().sendToDeadLetterAddress(null, ref);
+ synchronized (refs) {
+ refs.remove(ref.getMessageID());
Review Comment:
I believe this line here would change some metrics on queue. Removing the queue here will probably have a counter effect on the metrics, delivering... sizes...
Are you sure you don't have to counterweight these metrics after removing this?
Also, you should double check the message was acked on the SNF, and the message wouldn't return after a restart.
Issue Time Tracking
-------------------
Worklog Id: (was: 982845)
Time Spent: 3h 10m (was: 3h)
> Handle invalid messages in SNF queues
> -------------------------------------
>
> Key: ARTEMIS-4924
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4924
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 2.35.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Currently, if a poison message missing queue information ends up in the SF queue, the broker logs an error, like:
> {noformat}
> AMQ222110: no queue IDs defined...{noformat}
> However, the message remains in the queue with the result that the bridge continuously reconnects, encounters the failure, then evicts the bridge consumer.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact