You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "Marko A. Rodriguez (JIRA)" <ji...@apache.org> on 2016/10/21 18:51:58 UTC
[jira] [Commented] (TINKERPOP-1507) Pick.any and Pick.none are not
in GraphSON or Gremlin-Python
[ https://issues.apache.org/jira/browse/TINKERPOP-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595999#comment-15595999 ]
Marko A. Rodriguez commented on TINKERPOP-1507:
-----------------------------------------------
Went down the road of a {{Tokens.java}} file and its not good. Its only useful for JVM languages --- Python and others will have to do lots of conversions. Just going to stay the course and added {{Pick}} to the enum imports.
> Pick.any and Pick.none are not in GraphSON or Gremlin-Python
> ------------------------------------------------------------
>
> Key: TINKERPOP-1507
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1507
> Project: TinkerPop
> Issue Type: Improvement
> Components: io, language-variant, process
> Affects Versions: 3.1.4, 3.2.2
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
>
> There are numerous "tokens" (enums) in Gremlin -- {{T}}, {{Order}}, {{Compare}}, etc.
> We forgot {{Pick}}. Doh. {{Pick}} is used in branch-options to support "default" and "all"-type semantics in switch behavior. We need to add it to GraphSON and Gremlin-Python.
> More generally, I think we should consolidate all the "tokens" into a single Java file.
> {code}
> public class Tokens {
> public enum T { .. }
> public enum Order { .. }
> public enum VertexCardinality { ..}
> public enum Compare { .. }
> public enum Pick { .. }
> ...
> }
> {code}
> We could make it backwards compatible by:
> {code}
> T.label = Tokens.T.label.
> {code}
> By having all this consolidate, we will more easily know what we have and will be better able to use reflection in language variant generators.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)