You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/02/05 14:47:12 UTC

[GitHub] rymanluk commented on a change in pull request #786: nimble/ll: Fixes for couple of issues found in UPF59

rymanluk commented on a change in pull request #786: nimble/ll: Fixes for couple of issues found in UPF59
URL: https://github.com/apache/mynewt-core/pull/786#discussion_r165992083
 
 

 ##########
 File path: net/nimble/controller/src/ble_ll_conn_hci.c
 ##########
 @@ -1512,6 +1512,16 @@ ble_ll_conn_hci_le_set_phy(uint8_t *cmdbuf)
         return BLE_ERR_CMD_DISALLOWED;
     }
 
+    /*
+     * If we are a slave and the master has initiated the channel map
+     * update procedure we should deny the slave request for now.
 
 Review comment:
   well I agree with you. I will create Jira for this as there is at least one other place where we solve collision in the same way.  I will remove this patch from this PR then

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services