[GitHub] [cassandra] Mmuzaf commented on a diff in pull request #2699: CASSANDRA-18742 5.0 - removal of deprecated sstable_compression and chunk_length_kb

["Mmuzaf (via GitHub)" <gi...@apache.org>]

Mmuzaf commented on code in PR #2699:
URL: https://github.com/apache/cassandra/pull/2699#discussion_r1339241533


##########
test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java:
##########
@@ -702,26 +702,15 @@ public void testAlterTableWithCompression() throws Throwable
         alterTable("ALTER TABLE %s WITH compression = { 'enabled' : 'false'};");
         assertSchemaOption("compression", map("enabled", "false"));
 
-        assertAlterTableThrowsException(ConfigurationException.class,
-                                        "Missing sub-option 'class' for the 'compression' option.",
-                                        "ALTER TABLE %s WITH  compression = {'chunk_length_in_kb' : 32};");

Review Comment:
   As I can see the option `chunk_length_in_kb` should remain, right? We are removing `chunk_length_kb`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org