[GitHub] [ant] tsmock edited a comment on pull request #175: junitlauncher - Fix an issue in LegacyXmlResultFormatter with ]]> in stacktraces

[GitBox <gi...@apache.org>]

tsmock edited a comment on pull request #175:
URL: https://github.com/apache/ant/pull/175#issuecomment-1022226543


   > This PR looks fine to me. Thank you for fixing this. Given that we have had odd issues in this area with XML content, do you think it's possible to add a test case to reproduce this issue and verify the fix? If so, would you be willing to add one in this PR?
   
   I was looking into this yesterday. I'll say this much, figuring out how the tests were run and verified took me a bit of time, and the output from `./build.sh clean test` does _not_ have any mention of junitlauncher on my system. As in, it appears that those tests do not run with the suggested test command in CONTRIBUTING.md. I don't know if it is just my system or not (Mac OS X 12.1), so I was going to try it on a Raspberry Pi sometime today.
   
   EDIT: The `junitlauncher` tests did not run on the Pi either. I looked for `ant` CI and found https://builds.apache.org/job/Ant/job/Ant_Nightly/lastBuild/consoleText -- it looks like `junitlauncher` tests are _not_ running there either.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org