[GitHub] YingboWang opened a new pull request #3784: [AIRFLOW-2930] Fix celery excecutor scheduler crash

[GitBox <gi...@apache.org>]

YingboWang opened a new pull request #3784: [AIRFLOW-2930] Fix celery excecutor scheduler crash
URL: https://github.com/apache/incubator-airflow/pull/3784
 
 
   Caused by an update in PR #3740.
   execute_command.apply_async(args=command, ...)
   -command is a list of short unicode strings and the above code pass multiple
   arguments to a function defined as taking only one argument.
   -command = ["airflow", "run", "dag323",...]
   -args = command = ["airflow", "run", "dag323", ...]
   -execute_command("airflow","run","dag3s3", ...) will be error and exit.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-2930) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2930
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   -Fixing issue caused by https://github.com/apache/incubator-airflow/pull/3740
   
   -`execute_command.apply_async(args = command, queue = queue)` will pass a list of arguments rather than one to function `execute_command()` which is defined as taking only one argument. The test in `test_celery_executor.py` right now only have one item in the testing command list and can not cover this case.
   
   ### Tests
   
   - [x] My PR adds the following unit tests:
   >tests/executors/test_celery_executor.py CeleryExecutorTest:test_celery_integration_multiple_parameter()
   Tested.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   @bolkedebruin 
   @feng-tao 
   @yrqls21  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services