You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/07/27 20:51:50 UTC
[GitHub] [beam] damccorm opened a new pull request, #27722: Return a useful error when we fail to create a MonitoringInfo object
damccorm opened a new pull request, #27722:
URL: https://github.com/apache/beam/pull/27722
Right now, it is possible for users to increment counters incorrectly, leading to errors when we try to construct the counters. These errors are usually opaque and unhelpful (e.g. `TypeError: 123 has type numpy.int64, but expected one of: bytes`). These don't provide enough info to debug. This PR enriches these errors so that users can self serve issues by looking at the metric in question.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #27722: Return a useful error when we fail to create a MonitoringInfo object
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #27722:
URL: https://github.com/apache/beam/pull/27722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27722: Return a useful error when we fail to create a MonitoringInfo object
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27722:
URL: https://github.com/apache/beam/pull/27722#issuecomment-1654645547
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @tvalentyn for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #27722: Return a useful error when we fail to create a MonitoringInfo object
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #27722:
URL: https://github.com/apache/beam/pull/27722#discussion_r1276883314
##########
sdks/python/apache_beam/metrics/monitoring_infos.py:
##########
@@ -299,8 +299,13 @@ def create_monitoring_info(urn, type_urn, payload, labels=None):
payload: The payload field to use in the monitoring info.
labels: The label dictionary to use in the MonitoringInfo.
"""
- return metrics_pb2.MonitoringInfo(
- urn=urn, type=type_urn, labels=labels or {}, payload=payload)
+ try:
+ return metrics_pb2.MonitoringInfo(
+ urn=urn, type=type_urn, labels=labels or {}, payload=payload)
+ except TypeError as e:
+ raise Exception(
Review Comment:
consider ValueError or RuntimeError instead of generic Exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #27722: Return a useful error when we fail to create a MonitoringInfo object
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27722:
URL: https://github.com/apache/beam/pull/27722#discussion_r1276986290
##########
sdks/python/apache_beam/metrics/monitoring_infos.py:
##########
@@ -299,8 +299,13 @@ def create_monitoring_info(urn, type_urn, payload, labels=None):
payload: The payload field to use in the monitoring info.
labels: The label dictionary to use in the MonitoringInfo.
"""
- return metrics_pb2.MonitoringInfo(
- urn=urn, type=type_urn, labels=labels or {}, payload=payload)
+ try:
+ return metrics_pb2.MonitoringInfo(
+ urn=urn, type=type_urn, labels=labels or {}, payload=payload)
+ except TypeError as e:
+ raise Exception(
Review Comment:
Good call - RuntimeError seems reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #27722: Return a useful error when we fail to create a MonitoringInfo object
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27722:
URL: https://github.com/apache/beam/pull/27722#issuecomment-1654632382
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27722?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#27722](https://app.codecov.io/gh/apache/beam/pull/27722?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1b3d3f3) into [master](https://app.codecov.io/gh/apache/beam/commit/c3f1675019254ba88ce996f3d946b3f973a13282?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c3f1675) will **increase** coverage by `0.00%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #27722 +/- ##
=======================================
Coverage 70.89% 70.89%
=======================================
Files 860 860
Lines 104632 104635 +3
=======================================
+ Hits 74175 74186 +11
+ Misses 28903 28895 -8
Partials 1554 1554
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `80.01% <50.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/beam/pull/27722?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...dks/python/apache\_beam/metrics/monitoring\_infos.py](https://app.codecov.io/gh/apache/beam/pull/27722?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tb25pdG9yaW5nX2luZm9zLnB5) | `91.62% <50.00%> (-0.88%)` | :arrow_down: |
... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/27722/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org