You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/30 11:32:50 UTC
[GitHub] [flink] zhengcanbin opened a new pull request #10973: Flink 15647
zhengcanbin opened a new pull request #10973: Flink 15647
URL: https://github.com/apache/flink/pull/10973
## What is the purpose of the change
This PR introduces customized annotations support for JobManager/TaskManager Pods.
## Verifying this change
This change added tests and can be verified as follows:
- *Specify new command-line parameters when deploying a session cluster, such as `-Dkubernetes.jobmanager.annotation.test1=abc -Dkubernetes.jobmanager.annotation.test2=abc2 -Dkubernetes.taskmanager.annotation.test3=edf3 -Dkubernetes.taskmanager.annotation.test4=edf4`*
- *Manually check whether the newly created JobManager Pod has the customized annotations `test1=abc` and `test2=abc2`*
- *Submit a Job to the running session cluster, then manually check whether the newly created TaskManager Pod has the customized annotations `test3=edf3` and `test4=edf4`*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537476",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6532",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154581010",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
}, {
"hash" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154606765",
"triggerID" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"triggerType" : "PUSH"
}, {
"hash" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6537",
"triggerID" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b UNKNOWN
* efac68a938b6e2a9a4a5f17cd0b57deac69043a3 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154581010) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6532)
* 29a819da0513b97fb78e586ef884bfa27b4eeb89 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154606765) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6537)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r396231613
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesTaskManagerParameters.java
##########
@@ -67,6 +68,11 @@ public KubernetesTaskManagerParameters(
return this.containeredTaskManagerParameters.taskManagerEnv();
}
+ @Override
+ public Map<String, String> getAnnotations() {
Review comment:
Sounds reasonable. Have marked it Nullable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72aae7d37888a080b735d194dacc6ff457e741ca Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154452746) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537476",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6532",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154581010",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
}, {
"hash" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154606765",
"triggerID" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"triggerType" : "PUSH"
}, {
"hash" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6537",
"triggerID" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b UNKNOWN
* 29a819da0513b97fb78e586ef884bfa27b4eeb89 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154606765) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6537)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 191ef66efb99cd9504dda55e4957c11e02415913 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154361586) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebd5df4e38fadb8e004edf078e485127c4de97af Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154357409) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537476",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 33776e6aa098656ddb2820bbac39b4b08f9fa3f8 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154537476) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505)
* 3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
Hash:d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677 TriggerType:PUSH TriggerID:d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241
Hash:d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146742860 TriggerType:PUSH TriggerID:d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241
-->
## CI report:
* d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146742860) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
Hash:d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241
-->
## CI report:
* d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r396885299
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java
##########
@@ -63,6 +65,12 @@ public KubernetesJobManagerParameters(Configuration flinkConfig, ClusterSpecific
return getPrefixedEnvironments(ResourceManagerOptions.CONTAINERIZED_MASTER_ENV_PREFIX);
}
+ @Nullable
Review comment:
Done via [29a819d](https://github.com/apache/flink/pull/10973/commits/29a819da0513b97fb78e586ef884bfa27b4eeb89)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146742860) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677)
* ebd5df4e38fadb8e004edf078e485127c4de97af UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537476",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6532",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154581010",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
}, {
"hash" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154606765",
"triggerID" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"triggerType" : "PUSH"
}, {
"hash" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6537",
"triggerID" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b UNKNOWN
* 29a819da0513b97fb78e586ef884bfa27b4eeb89 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154606765) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6537)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537476",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 33776e6aa098656ddb2820bbac39b4b08f9fa3f8 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154537476) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505)
* 3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b UNKNOWN
* efac68a938b6e2a9a4a5f17cd0b57deac69043a3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebd5df4e38fadb8e004edf078e485127c4de97af Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154357409) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462)
* 191ef66efb99cd9504dda55e4957c11e02415913 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154361586) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#discussion_r395577026
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX = "kubernetes.jobmanager.annotation.";
Review comment:
Thanks for the explanation! It makes sense to me. I will change it to the map type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#discussion_r395465724
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX = "kubernetes.jobmanager.annotation.";
Review comment:
The configuration in the document will not contain this config options.
https://ci.apache.org/projects/flink/flink-docs-master/ops/config.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537476",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6532",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154581010",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
}, {
"hash" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154606765",
"triggerID" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"triggerType" : "PUSH"
}, {
"hash" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6537",
"triggerID" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b UNKNOWN
* 29a819da0513b97fb78e586ef884bfa27b4eeb89 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154606765) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6537)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #10973: [FLINK-15647][k8s]
Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 191ef66efb99cd9504dda55e4957c11e02415913 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154361586) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537476",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6532",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154581010",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
}, {
"hash" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29a819da0513b97fb78e586ef884bfa27b4eeb89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 33776e6aa098656ddb2820bbac39b4b08f9fa3f8 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154537476) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505)
* 3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b UNKNOWN
* efac68a938b6e2a9a4a5f17cd0b57deac69043a3 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154581010) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6532)
* 29a819da0513b97fb78e586ef884bfa27b4eeb89 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#discussion_r395540341
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX = "kubernetes.jobmanager.annotation.";
Review comment:
I also notice that [FLINK-15640](https://issues.apache.org/jira/browse/FLINK-15640) plans to use the map config option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r396222138
##########
File path: docs/_includes/generated/kubernetes_config_configuration.html
##########
@@ -104,5 +104,17 @@
<td>Double</td>
<td>The number of cpu used by task manager. By default, the cpu is set to the number of slots per TaskManager</td>
</tr>
+ <tr>
Review comment:
I think the document is not generated by `mvn package -Dgenerate-config-docs -pl flink-docs -am -nsu -DskipTests`. It will be a problem if others re-generate the doc in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#issuecomment-601556745
> Thanks for creating this PR @zhengcanbin. The changes look good to me.
>
> Please rebase the PR onto the latest master. There are currently some merge conflicts. Once you have done this and Travis gives green light, then I will merge this PR.
Thanks a lot for the review @tillrohrmann! This PR relies on [FLINK-16625](https://issues.apache.org/jira/browse/FLINK-16625). I will push a new commit base on FLINK-16625, meanwhile resolve the conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebd5df4e38fadb8e004edf078e485127c4de97af Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154357409) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462)
* 191ef66efb99cd9504dda55e4957c11e02415913 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 191ef66efb99cd9504dda55e4957c11e02415913 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154361586) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465)
* 72aae7d37888a080b735d194dacc6ff457e741ca UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #10973: [FLINK-15647][k8s]
Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-602159300
Hi @tillrohrmann! I have resolved the comments and both the Travis and Azure give a green light. Kindly expect to see your reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#discussion_r395121145
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesUtilsTest.java
##########
@@ -83,6 +85,21 @@
private static final String tmMemDynamicProperties =
TaskExecutorProcessUtils.generateDynamicConfigsStr(TASK_EXECUTOR_PROCESS_SPEC).trim();
+ @Test
+ public void testParsePrefixedKVPairs() {
+ final Configuration cfg = new Configuration();
+ cfg.setString("kubernetes.jobmanager.annotation.a1", "value1");
+ cfg.setString("kubernetes.jobmanager.annotation.a2", "value2");
+
+ final Map<String, String> ret = KubernetesUtils.parsePrefixedKVPairs(cfg, "kubernetes.jobmanager.annotation.");
+
+ assertEquals(2, ret.size());
+ assertTrue(ret.containsKey("a1"));
+ assertTrue(ret.containsKey("a2"));
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r396335787
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesParameters.java
##########
@@ -56,6 +56,11 @@
*/
Map<String, String> getEnvironments();
+ /**
+ * A map of user-specified annotations that are set to the JobManager and TaskManager Pod.
+ */
+ Map<String, String> getAnnotations();
Review comment:
Why not returning an empty map?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r395536051
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX = "kubernetes.jobmanager.annotation.";
Review comment:
1. Since the value can contain `:` and `,`, it seems we could not use the map type.
2. We could add descriptions too in the document, just like what we have done for the `containerized.master.env.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#discussion_r395536051
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX = "kubernetes.jobmanager.annotation.";
Review comment:
1. Since the value can contain `:` and `,`, we should not use the map type.
2. We could add descriptions too in the document, just like what we have done for the `containerized.master.env.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r396336277
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java
##########
@@ -63,6 +65,12 @@ public KubernetesJobManagerParameters(Configuration flinkConfig, ClusterSpecific
return getPrefixedEnvironments(ResourceManagerOptions.CONTAINERIZED_MASTER_ENV_PREFIX);
}
+ @Nullable
Review comment:
This should either go to the interface `KubernetesParameters` or preferrably we return an empty map if it has not been set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#discussion_r395573866
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX = "kubernetes.jobmanager.annotation.";
Review comment:
I think the map `ConfigOption` type supports to escape keys and values. Hence, if the user would need to define a value with `:` he could write it: `kubernetes.taskmanager.annotations: key1:'value:foobar','key:2':value`, for example. From that perspective I think it would indeed be better to use a map config option as @wangyang0918 suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72aae7d37888a080b735d194dacc6ff457e741ca Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154452746) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479)
* 33776e6aa098656ddb2820bbac39b4b08f9fa3f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#discussion_r395963154
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX = "kubernetes.jobmanager.annotation.";
Review comment:
That would be nice, let's do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146742860) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677)
* ebd5df4e38fadb8e004edf078e485127c4de97af Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154357409) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r396234421
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesParameters.java
##########
@@ -56,6 +56,11 @@
*/
Map<String, String> getEnvironments();
+ /**
+ * A map of user-specified annotations that are set to the JobManager and TaskManager Pod.
+ */
+ Map<String, String> getAnnotations();
Review comment:
Marked as `Nullable` and document it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537476",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72aae7d37888a080b735d194dacc6ff457e741ca Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154452746) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479)
* 33776e6aa098656ddb2820bbac39b4b08f9fa3f8 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154537476) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505)
* 3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r396225295
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesTaskManagerParameters.java
##########
@@ -67,6 +68,11 @@ public KubernetesTaskManagerParameters(
return this.containeredTaskManagerParameters.taskManagerEnv();
}
+ @Override
+ public Map<String, String> getAnnotations() {
Review comment:
Maybe we could add `Nullable` here or using `flinkConfig.getOptional`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#issuecomment-580212757
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241 (Thu Jan 30 11:36:07 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15647).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r396231441
##########
File path: docs/_includes/generated/kubernetes_config_configuration.html
##########
@@ -104,5 +104,17 @@
<td>Double</td>
<td>The number of cpu used by task manager. By default, the cpu is set to the number of slots per TaskManager</td>
</tr>
+ <tr>
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r396237837
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesParameters.java
##########
@@ -56,6 +56,11 @@
*/
Map<String, String> getEnvironments();
+ /**
+ * A map of user-specified annotations that are set to the JobManager and TaskManager Pod.
+ */
+ Map<String, String> getAnnotations();
Review comment:
Nice tips. Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#discussion_r395465724
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX = "kubernetes.jobmanager.annotation.";
Review comment:
The configuration in the document will not contain this config options.
https://ci.apache.org/projects/flink/flink-docs-master/ops/config.html
So i am not sure to use the prefix or config option with map type. @tillrohrmann What do you think?
```
public static final ConfigOption<Map<String, String>> TASK_MANAGER_ANNOTATIONS =
key("kubernetes.taskmanager.annotations")
.mapType()
.noDefaultValue()
.withDescription("xxxx");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 191ef66efb99cd9504dda55e4957c11e02415913 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154361586) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465)
* 72aae7d37888a080b735d194dacc6ff457e741ca Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154452746) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
zhengcanbin edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-602159300
Hi @tillrohrmann! I have addressed the comments and the Travis gives a green light. Kindly expect to see your reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r396336700
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesTaskManagerParameters.java
##########
@@ -67,6 +68,11 @@ public KubernetesTaskManagerParameters(
return this.containeredTaskManagerParameters.taskManagerEnv();
}
+ @Override
+ public Map<String, String> getAnnotations() {
Review comment:
I think an empty map would be easiest to understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#discussion_r395577026
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX = "kubernetes.jobmanager.annotation.";
Review comment:
Thanks for the explanation! It makes sense to me, will change it to the map type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#discussion_r395540341
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX = "kubernetes.jobmanager.annotation.";
Review comment:
I also notice that [FLINK-15640](https://issues.apache.org/jira/browse/FLINK-15640) plans to use the map config option. It could confuse the users that we use map type for labels/node-selectors and use string type for annotations.
@tillrohrmann @TisonKun Do we have guides on whether we should use the map type for a config option that is exposed to the users?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#discussion_r395651747
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX = "kubernetes.jobmanager.annotation.";
Review comment:
Yes, the key and value of map could be escaped.
@zhengcanbin FLINK-15640 will keep the same behavior with this ticket with using map type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72aae7d37888a080b735d194dacc6ff457e741ca Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154452746) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537476",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 33776e6aa098656ddb2820bbac39b4b08f9fa3f8 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154537476) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505)
* 3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154357409",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6462",
"triggerID" : "ebd5df4e38fadb8e004edf078e485127c4de97af",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6465",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "191ef66efb99cd9504dda55e4957c11e02415913",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154361586",
"triggerID" : "191ef66efb99cd9504dda55e4957c11e02415913",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154452746",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6479",
"triggerID" : "72aae7d37888a080b735d194dacc6ff457e741ca",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537476",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505",
"triggerID" : "33776e6aa098656ddb2820bbac39b4b08f9fa3f8",
"triggerType" : "PUSH"
}, {
"hash" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6532",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
}, {
"hash" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154581010",
"triggerID" : "efac68a938b6e2a9a4a5f17cd0b57deac69043a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 33776e6aa098656ddb2820bbac39b4b08f9fa3f8 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154537476) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6505)
* 3bfbfa984bf69d1abf17594aabd4b0e3ec1f782b UNKNOWN
* efac68a938b6e2a9a4a5f17cd0b57deac69043a3 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154581010) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r396345282
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesTaskManagerParameters.java
##########
@@ -67,6 +68,11 @@ public KubernetesTaskManagerParameters(
return this.containeredTaskManagerParameters.taskManagerEnv();
}
+ @Override
+ public Map<String, String> getAnnotations() {
Review comment:
I have used `flinkConfig.getOptional(KubernetesConfigOptions.JOB_MANAGER_NODE_SELECTOR).orElse(Collections.emptyMap())` in the label/node-selector support PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
}, {
"hash" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/146742860",
"triggerID" : "d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146742860) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #10973: [FLINK-15647][k8s]
Support user-specified annotations for JM/TM Pods
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#issuecomment-602995223
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10973: [FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#issuecomment-580223229
<!--
Meta data
Hash:d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677 TriggerType:PUSH TriggerID:d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241
Hash:d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146742860 TriggerType:PUSH TriggerID:d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241
-->
## CI report:
* d188a8ae64d7405af0d32a7bcb8c2c2f45ca5241 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146742860) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4677)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services