[GitHub] [incubator-superset] serenajiang opened a new pull request #8138: [typing] add typing for superset/connectors and superset/common

[GitBox <gi...@apache.org>]

serenajiang opened a new pull request #8138: [typing] add typing for superset/connectors and superset/common
URL: https://github.com/apache/incubator-superset/pull/8138
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [X] Documentation
   
   ### SUMMARY
   Added typing to most of `superset/connectors` and `superset/common`. Fun stuff. I left a few of the more confusing methods untyped.
   
   Possible issues:
   * Occasionally treating sqlalchemy `Column`s as their corresponding python types.
   * `# noqa` in a number of places. Mostly issues with dicts and missing return statements.
   
   ### TEST PLAN
   tox passes for py36 and flake8.
   
   ### REVIEWERS
   @etr2460 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org