You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jesper Pedersen (JIRA)" <de...@myfaces.apache.org> on 2007/01/05 13:07:27 UTC
[jira] Created: (TOMAHAWK-844) externalLink doesn't work if
layout="table"
externalLink doesn't work if layout="table"
-------------------------------------------
Key: TOMAHAWK-844
URL: https://issues.apache.org/jira/browse/TOMAHAWK-844
Project: MyFaces Tomahawk
Issue Type: Bug
Components: Panel Navigation2
Affects Versions: 1.1.5-SNAPSHOT
Environment: JDK-1.5_10 + TOMAHAWK-1.1.5 branch + CORE-1.1.5 branch
Reporter: Jesper Pedersen
The externalLink attribute for commandNavigation2 doesn't work if the parent panelNavigation2 has its layout set to "table".
<t:panelNavigation2 layout="table">
<t:commandNavigation2 value="#{messages['nav.home']}" externalLink="/home.jsf" target="_top"/>
<t:commandNavigation2 value="#{messages['nav.products']}" externalLink="/products.jsf" target="_top"/>
The output renders <a href="#" ...> instead.
Also there seems to be a problem with rendering the first item in the commandNaviation2 list:
<ul>
<li></li>
<li><a href="/products.jsf" target="_top"></a><ul></ul></li>
Please, note that this output is from layout="list".
Fixing this issue would help GoogleBot a lot with crawling sites when layout="list" isn't an option.
Hope this makes sense.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-844) externalLink doesn't work if
layout="table"
Posted by "Jesper Pedersen (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464188 ]
Jesper Pedersen commented on TOMAHAWK-844:
------------------------------------------
The problem seems to located in HtmlNavigationMenuRendererUtils as renderChildrenListLayout and renderChildrenTableLayout have different structure.
renderChildrenListLayout checks for externalLink.
renderChildrenTableLayout doesn't.
> externalLink doesn't work if layout="table"
> -------------------------------------------
>
> Key: TOMAHAWK-844
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-844
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Panel Navigation2
> Affects Versions: 1.1.5-SNAPSHOT
> Environment: JDK-1.5_10 + TOMAHAWK-1.1.5 branch + CORE-1.1.5 branch
> Reporter: Jesper Pedersen
>
> The externalLink attribute for commandNavigation2 doesn't work if the parent panelNavigation2 has its layout set to "table".
> <t:panelNavigation2 layout="table">
> <t:commandNavigation2 value="#{messages['nav.home']}" externalLink="/home.jsf" target="_top"/>
> <t:commandNavigation2 value="#{messages['nav.products']}" externalLink="/products.jsf" target="_top"/>
> The output renders <a href="#" ...> instead.
> Also there seems to be a problem with rendering the first item in the commandNaviation2 list:
> <ul>
> <li></li>
> <li><a href="/products.jsf" target="_top"></a><ul></ul></li>
> Please, note that this output is from layout="list".
> Fixing this issue would help GoogleBot a lot with crawling sites when layout="list" isn't an option.
> Hope this makes sense.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-844) externalLink doesn't work if
layout="table"
Posted by "Jesper Pedersen (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464191 ]
Jesper Pedersen commented on TOMAHAWK-844:
------------------------------------------
One more problem: The 'value' isn't used for the <a href>.
The link above in the example should read:
<a href="/products.jsf" target="_top">Products</a>
The 'Products' is currently missing in HTML code.
> externalLink doesn't work if layout="table"
> -------------------------------------------
>
> Key: TOMAHAWK-844
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-844
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Panel Navigation2
> Affects Versions: 1.1.5-SNAPSHOT
> Environment: JDK-1.5_10 + TOMAHAWK-1.1.5 branch + CORE-1.1.5 branch
> Reporter: Jesper Pedersen
>
> The externalLink attribute for commandNavigation2 doesn't work if the parent panelNavigation2 has its layout set to "table".
> <t:panelNavigation2 layout="table">
> <t:commandNavigation2 value="#{messages['nav.home']}" externalLink="/home.jsf" target="_top"/>
> <t:commandNavigation2 value="#{messages['nav.products']}" externalLink="/products.jsf" target="_top"/>
> The output renders <a href="#" ...> instead.
> Also there seems to be a problem with rendering the first item in the commandNaviation2 list:
> <ul>
> <li></li>
> <li><a href="/products.jsf" target="_top"></a><ul></ul></li>
> Please, note that this output is from layout="list".
> Fixing this issue would help GoogleBot a lot with crawling sites when layout="list" isn't an option.
> Hope this makes sense.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira