You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/04/07 00:29:11 UTC
[GitHub] [beam] emilymye commented on a change in pull request #14452: [BEAM-12112] Disable streaming mode for PORTABILITY_BATCH
emilymye commented on a change in pull request #14452:
URL: https://github.com/apache/beam/pull/14452#discussion_r608261887
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java
##########
@@ -1162,6 +1163,11 @@ private void modelResultRates(NexmarkQueryModel model) {
return null;
}
+ if (configuration.query == PORTABILITY_BATCH && options.isStreaming()) {
+ NexmarkUtils.console("Query 13 does not support streaming mode");
Review comment:
nit - maybe have "skipping" prefix here since this reads a bit right now like it should throw an error instead of just skipping if in streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org