You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by GitBox <gi...@apache.org> on 2022/01/15 18:47:56 UTC

[GitHub] [incubator-linkis] pjfanning opened a new pull request #1309: upgrade poi and excel-streaming-reader

pjfanning opened a new pull request #1309:
URL: https://github.com/apache/incubator-linkis/pull/1309


   ### What is the purpose of the change
   Upgrade POI and excel-streaming-reader to pick up security and other bug fixes.
   
   Related issues: #1308 
   
   ### Brief change log
   - Change dependencies
   - Change licenses
   
   ### Verifying this change
   This change is already covered by existing tests, such as (please describe tests).  
   
   ### Does this pull request potentially affect one of the following parts:
   - Dependencies (does it add or upgrade a dependency): yes 
   - Anything that affects deployment: no
   - The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: no
   
   ### Documentation
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong commented on pull request #1309: upgrade poi and excel-streaming-reader

Posted by GitBox <gi...@apache.org>.
peacewong commented on pull request #1309:
URL: https://github.com/apache/incubator-linkis/pull/1309#issuecomment-1022285257


   Please help to check the binary license @casionone 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong commented on pull request #1309: upgrade poi and excel-streaming-reader

Posted by GitBox <gi...@apache.org>.
peacewong commented on pull request #1309:
URL: https://github.com/apache/incubator-linkis/pull/1309#issuecomment-1014238231


   > @peacewong could you approve the CI build when you get a chance?
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong commented on pull request #1309: upgrade poi and excel-streaming-reader

Posted by GitBox <gi...@apache.org>.
peacewong commented on pull request #1309:
URL: https://github.com/apache/incubator-linkis/pull/1309#issuecomment-1015149450


   > @peacewong I'm not very familiar with the Linkis build - I'm not sure why the nodejs build timed out.
   build is ok, because linkis 1.0.3-rc2 version is under voting, this pr will be merged into the latest code after version release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong commented on pull request #1309: upgrade poi and excel-streaming-reader

Posted by GitBox <gi...@apache.org>.
peacewong commented on pull request #1309:
URL: https://github.com/apache/incubator-linkis/pull/1309#issuecomment-1015142598


   > @peacewong I'm not very familiar with the Linkis build - I'm not sure why the nodejs build timed out.
   
   Seems to be a github action issue, I restarted the build


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] pjfanning commented on pull request #1309: upgrade poi and excel-streaming-reader

Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #1309:
URL: https://github.com/apache/incubator-linkis/pull/1309#issuecomment-1013739308


   @peacewong could you approve the CI build when you get a chance?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong merged pull request #1309: upgrade poi and excel-streaming-reader

Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1309:
URL: https://github.com/apache/incubator-linkis/pull/1309


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong removed a comment on pull request #1309: upgrade poi and excel-streaming-reader

Posted by GitBox <gi...@apache.org>.
peacewong removed a comment on pull request #1309:
URL: https://github.com/apache/incubator-linkis/pull/1309#issuecomment-1015149450


   > @peacewong I'm not very familiar with the Linkis build - I'm not sure why the nodejs build timed out.
   build is ok, because linkis 1.0.3-rc2 version is under voting, this pr will be merged into the latest code after version release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] casionone commented on pull request #1309: upgrade poi and excel-streaming-reader

Posted by GitBox <gi...@apache.org>.
casionone commented on pull request #1309:
URL: https://github.com/apache/incubator-linkis/pull/1309#issuecomment-1022790617


   @pjfanning 
   In addition, for the scenario of dependent modification, I think it is necessary to add automatic verification checks to the git action in the future. 
   Would you like to take this task?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] pjfanning commented on pull request #1309: upgrade poi and excel-streaming-reader

Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #1309:
URL: https://github.com/apache/incubator-linkis/pull/1309#issuecomment-1014784130


   @peacewong I'm not very familiar with the Linkis build - I'm not sure why the nodejs build timed out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong commented on pull request #1309: upgrade poi and excel-streaming-reader

Posted by GitBox <gi...@apache.org>.
peacewong commented on pull request #1309:
URL: https://github.com/apache/incubator-linkis/pull/1309#issuecomment-1015149660


   > @peacewong I'm not very familiar with the Linkis build - I'm not sure why the nodejs build timed out.
   
   build is ok, because linkis 1.0.3-rc2 version is under voting, this pr will be merged into the latest code after version release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] casionone commented on pull request #1309: upgrade poi and excel-streaming-reader

Posted by GitBox <gi...@apache.org>.
casionone commented on pull request #1309:
URL: https://github.com/apache/incubator-linkis/pull/1309#issuecomment-1022787335


   > Please help to check the binary license @casionone
   I checked and it works fine for me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org