[jira] [Commented] (ZOOKEEPER-1719) zkCli.sh, zkServer.sh and zkEnv.sh regression caused by ZOOKEEPER-1663

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694078#comment-13694078 ] 

Hadoop QA commented on ZOOKEEPER-1719:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12589768/ZOOKEEPER-1719.patch
  against trunk revision 1495522.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1506//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1506//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1506//console

This message is automatically generated.
                
> zkCli.sh, zkServer.sh and zkEnv.sh regression caused by ZOOKEEPER-1663
> ----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1719
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1719
>             Project: ZooKeeper
>          Issue Type: Bug
>         Environment: Linux (Ubuntu 12.04) with dash shell
>            Reporter: Marshall McMullen
>            Assignee: Marshall McMullen
>         Attachments: ZOOKEEPER-1719.patch
>
>
> This fix from ZOOKEEPER-1663 is incorrect. It assumes the shell is bash since it uses bash array construction, e.g.:
> {code}
>  96   LIBPATH=("${ZOOKEEPER_PREFIX}"/share/zookeeper/*.jar)
> {code}
> This does NOT work if /bin/sh points to /bin/dash as it does on Ubuntu. 
> It fails as so:
> {quote}
> zkEnv.sh: 96: zkEnv.sh: Syntax error: "(" unexpected (expecting "fi")                                                                                                                                                                                              
> {quote}
> If I change the shebang at the top to use "/bin/bash" instead of "/bin/sh" it works as expected. I don't know the full details of why using a bash array was chosen as the solution but I don't think it is the right way to deal with spaces in these paths...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira