You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Daniel Estévez <no...@github.com> on 2018/05/03 20:11:31 UTC

[jclouds/jclouds] Protects from NPE since SecurityGroup.getLocation() is nullable (#1201)

Right now running the AzureComputeSecurityGroupExtensionLiveTest will fail with a NPE if you have any securityGroup in you subscription in any location not included in Set<String> locations

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1201

-- Commit Summary --

  * Protects from NPE input.getLocation() is nullable

-- File Changes --

    M providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/extensions/AzureComputeSecurityGroupExtension.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1201.patch
https://github.com/jclouds/jclouds/pull/1201.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1201

Re: [jclouds/jclouds] Protects from NPE since SecurityGroup.getLocation() is nullable (#1201)

Posted by Ignasi Barrera <no...@github.com>.

Closed #1201.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1201#event-1609362060

Re: [jclouds/jclouds] Protects from NPE since SecurityGroup.getLocation() is nullable (#1201)

Posted by Ignasi Barrera <no...@github.com>.

Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/7c592703) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a32690a2). Thanks @danielestevez!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1201#issuecomment-386540266

Re: [jclouds/jclouds] Protects from NPE since SecurityGroup.getLocation() is nullable (#1201)

Posted by Ignasi Barrera <no...@github.com>.

nacx approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1201#pullrequestreview-117529420