You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by jf...@apache.org on 2007/02/02 17:27:54 UTC
svn commit: r502649 - /tomcat/connectors/trunk/jk/native/common/jk_global.h
Author: jfclere
Date: Fri Feb 2 08:27:53 2007
New Revision: 502649
URL: http://svn.apache.org/viewvc?view=rev&rev=502649
Log:
Otherwise it doesn't compile with gcc on HPUX.
Modified:
tomcat/connectors/trunk/jk/native/common/jk_global.h
Modified: tomcat/connectors/trunk/jk/native/common/jk_global.h
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_global.h?view=diff&rev=502649&r1=502648&r2=502649
==============================================================================
--- tomcat/connectors/trunk/jk/native/common/jk_global.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_global.h Fri Feb 2 08:27:53 2007
@@ -142,7 +142,7 @@
#include <netinet/tcp.h>
#include <arpa/inet.h>
#include <sys/un.h>
-#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
+#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) && !defined(HPUX11)
#include <sys/socketvar.h>
#endif
#if !defined(HPUX11) && !defined(AS400)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r502649 - /tomcat/connectors/trunk/jk/native/common/jk_global.h
Posted by Jim Jagielski <ji...@jaguNET.com>.
It sounds as though the problem is that even though the
header exists under HPUX, it is unusable.
So we may still need to explicit HPUX test... I'll
review the autoconf stuff to see if we can
force undef'ing the HAVE_* for HPUX.
On Feb 5, 2007, at 2:52 AM, Jean-Frederic wrote:
> Hi,
>
> I have tested, AC_CHECK_HEADERS() does not help:
> +++
> checking sys/socketvar.h usability... no
> checking sys/socketvar.h presence... yes
> configure: WARNING: sys/socketvar.h: present but cannot be compiled
> configure: WARNING: sys/socketvar.h: check for missing
> prerequisite
> headers?
> configure: WARNING: sys/socketvar.h: see the Autoconf documentation
> configure: WARNING: sys/socketvar.h: section "Present But
> Cannot Be
> Compiled"
> configure: WARNING: sys/socketvar.h: proceeding with the
> preprocessor's
> result
> configure: WARNING: sys/socketvar.h: in the future, the compiler will
> take precedence
> checking for sys/socketvar.h... yes
> +++
> And in common/portable.h:
> +++
> /* Define to 1 if you have the <sys/select.h> header file. */
> #define HAVE_SYS_SELECT_H 1
>
> /* Define to 1 if you have the <sys/socketvar.h> header file. */
> #define HAVE_SYS_SOCKETVAR_H 1
> +++
>
> Cheers
>
> Jean-Frederic
>
> On Fri, 2007-02-02 at 18:36 +0100, Rainer Jung wrote:
>> I can't test on HP-UX, but maybe you (jfc) could try:
>> Index: configure.in
>> ===================================================================
>> --- configure.in (revision 502659)
>> +++ configure.in (working copy)
>> @@ -139,6 +139,10 @@
>> dnl check for filio.h used on Solaris to define FIONREAD ioctl.
>> AC_CHECK_HEADERS(sys/filio.h)
>>
>> +dnl check for socketvar.h and select.h not used on HPUX11
>> +AC_CHECK_HEADERS(sys/socketvar.h)
>> +AC_CHECK_HEADERS(sys/select.h)
>> +
>> AC_DEFUN([JK_CHECK_SETSOCKOPT], [
>> AC_MSG_CHECKING(whether to use $1 with setsockopt())
>> AC_TRY_RUN([
>> Index: common/jk_global.h
>> ===================================================================
>> --- common/jk_global.h (revision 502659)
>> +++ common/jk_global.h (working copy)
>> @@ -142,10 +142,10 @@
>> #include <netinet/tcp.h>
>> #include <arpa/inet.h>
>> #include <sys/un.h>
>> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
>> !defined(HPUX11)
>> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
>> !defined(HAVE_SYS_SOCKETVAR_H)
>> #include <sys/socketvar.h>
>> #endif
>> -#if !defined(HPUX11) && !defined(AS400)
>> +#if !defined(HAVE_SYS_SELECT_H) && !defined(AS400)
>> #include <sys/select.h>
>> #endif
>> #endif
>>
>> Of course you would need to rebuild configure via buildconf.sh after
>> changing configure.in.
>>
>> Regards,
>>
>> Rainer
>>
>>
>> Jim Jagielski wrote:
>>> Don't we also have a HPUX11 specific check like
>>> the 2nd line after this one? Seems consistent to me :/
>>>
>>> On Feb 2, 2007, at 12:14 PM, Rainer Jung wrote:
>>>
>>>> Hi Jean-Frederic,
>>>>
>>>> shouldn't we be able to find out about the necessity to include
>>>> it via
>>>> configure? At least HP-UX should be able to use the configure
>>>> mechanism. I think we mostly use the hard coded defines for the
>>>> platforms, where we can't use the configure mechanism.
>>>>
>>>> Regards,
>>>>
>>>> Rainer
>>>>
>>>> jfclere@apache.org wrote:
>>>>> Author: jfclere
>>>>> Date: Fri Feb 2 08:27:53 2007
>>>>> New Revision: 502649
>>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=502649
>>>>> Log:
>>>>> Otherwise it doesn't compile with gcc on HPUX.
>>>>> Modified:
>>>>> tomcat/connectors/trunk/jk/native/common/jk_global.h
>>>>> Modified: tomcat/connectors/trunk/jk/native/common/jk_global.h
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/
>>>>> common/jk_global.h?view=diff&rev=502649&r1=502648&r2=502649
>>>>>
>>>>> ==================================================================
>>>>> ============
>>>>>
>>>>> --- tomcat/connectors/trunk/jk/native/common/jk_global.h
>>>>> (original)
>>>>> +++ tomcat/connectors/trunk/jk/native/common/jk_global.h Fri
>>>>> Feb 2
>>>>> 08:27:53 2007
>>>>> @@ -142,7 +142,7 @@
>>>>> #include <netinet/tcp.h>
>>>>> #include <arpa/inet.h>
>>>>> #include <sys/un.h>
>>>>> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
>>>>> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined
>>>>> (CYGWIN) &&
>>>>> !defined(HPUX11)
>>>>> #include <sys/socketvar.h>
>>>>> #endif
>>>>> #if !defined(HPUX11) && !defined(AS400)
>>>>> ------------------------------------------------------------------
>>>>> ---
>>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>> --kippdata informationstechnologie GmbH
>>>> Bornheimer Str. 33a
>>>> 53111 Bonn
>>>>
>>>> Tel.: 0228/98549-0
>>>> Fax: 0228/98549-50
>>>> www.kippdata.de
>>>> =======================
>>>> kippdata informationstechnologie GmbH
>>>> Bornheimer Str. 33a
>>>> D-53111 Bonn
>>>>
>>>> Tel.: +49/0228/98549-0
>>>> Fax: +49/0228/98549-50
>>>> www.kippdata.de
>>>>
>>>> -------------------------------------------------------------------
>>>> --
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>
>>>
>>> --------------------------------------------------------------------
>>> -
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>
>> --
>> kippdata informationstechnologie GmbH
>> Bornheimer Str. 33a
>> 53111 Bonn
>>
>> Tel.: 0228/98549-0
>> Fax: 0228/98549-50
>> www.kippdata.de
>> =======================
>> kippdata informationstechnologie GmbH
>> Bornheimer Str. 33a
>> D-53111 Bonn
>>
>> Tel.: +49/0228/98549-0
>> Fax: +49/0228/98549-50
>> www.kippdata.de
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r502649 -
/tomcat/connectors/trunk/jk/native/common/jk_global.h
Posted by Jean-Frederic <jf...@gmail.com>.
Hi,
I have tested, AC_CHECK_HEADERS() does not help:
+++
checking sys/socketvar.h usability... no
checking sys/socketvar.h presence... yes
configure: WARNING: sys/socketvar.h: present but cannot be compiled
configure: WARNING: sys/socketvar.h: check for missing prerequisite
headers?
configure: WARNING: sys/socketvar.h: see the Autoconf documentation
configure: WARNING: sys/socketvar.h: section "Present But Cannot Be
Compiled"
configure: WARNING: sys/socketvar.h: proceeding with the preprocessor's
result
configure: WARNING: sys/socketvar.h: in the future, the compiler will
take precedence
checking for sys/socketvar.h... yes
+++
And in common/portable.h:
+++
/* Define to 1 if you have the <sys/select.h> header file. */
#define HAVE_SYS_SELECT_H 1
/* Define to 1 if you have the <sys/socketvar.h> header file. */
#define HAVE_SYS_SOCKETVAR_H 1
+++
Cheers
Jean-Frederic
On Fri, 2007-02-02 at 18:36 +0100, Rainer Jung wrote:
> I can't test on HP-UX, but maybe you (jfc) could try:
> Index: configure.in
> ===================================================================
> --- configure.in (revision 502659)
> +++ configure.in (working copy)
> @@ -139,6 +139,10 @@
> dnl check for filio.h used on Solaris to define FIONREAD ioctl.
> AC_CHECK_HEADERS(sys/filio.h)
>
> +dnl check for socketvar.h and select.h not used on HPUX11
> +AC_CHECK_HEADERS(sys/socketvar.h)
> +AC_CHECK_HEADERS(sys/select.h)
> +
> AC_DEFUN([JK_CHECK_SETSOCKOPT], [
> AC_MSG_CHECKING(whether to use $1 with setsockopt())
> AC_TRY_RUN([
> Index: common/jk_global.h
> ===================================================================
> --- common/jk_global.h (revision 502659)
> +++ common/jk_global.h (working copy)
> @@ -142,10 +142,10 @@
> #include <netinet/tcp.h>
> #include <arpa/inet.h>
> #include <sys/un.h>
> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
> !defined(HPUX11)
> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
> !defined(HAVE_SYS_SOCKETVAR_H)
> #include <sys/socketvar.h>
> #endif
> -#if !defined(HPUX11) && !defined(AS400)
> +#if !defined(HAVE_SYS_SELECT_H) && !defined(AS400)
> #include <sys/select.h>
> #endif
> #endif
>
> Of course you would need to rebuild configure via buildconf.sh after
> changing configure.in.
>
> Regards,
>
> Rainer
>
>
> Jim Jagielski wrote:
> > Don't we also have a HPUX11 specific check like
> > the 2nd line after this one? Seems consistent to me :/
> >
> > On Feb 2, 2007, at 12:14 PM, Rainer Jung wrote:
> >
> >> Hi Jean-Frederic,
> >>
> >> shouldn't we be able to find out about the necessity to include it via
> >> configure? At least HP-UX should be able to use the configure
> >> mechanism. I think we mostly use the hard coded defines for the
> >> platforms, where we can't use the configure mechanism.
> >>
> >> Regards,
> >>
> >> Rainer
> >>
> >> jfclere@apache.org wrote:
> >>> Author: jfclere
> >>> Date: Fri Feb 2 08:27:53 2007
> >>> New Revision: 502649
> >>> URL: http://svn.apache.org/viewvc?view=rev&rev=502649
> >>> Log:
> >>> Otherwise it doesn't compile with gcc on HPUX.
> >>> Modified:
> >>> tomcat/connectors/trunk/jk/native/common/jk_global.h
> >>> Modified: tomcat/connectors/trunk/jk/native/common/jk_global.h
> >>> URL:
> >>> http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_global.h?view=diff&rev=502649&r1=502648&r2=502649
> >>>
> >>> ==============================================================================
> >>>
> >>> --- tomcat/connectors/trunk/jk/native/common/jk_global.h (original)
> >>> +++ tomcat/connectors/trunk/jk/native/common/jk_global.h Fri Feb 2
> >>> 08:27:53 2007
> >>> @@ -142,7 +142,7 @@
> >>> #include <netinet/tcp.h>
> >>> #include <arpa/inet.h>
> >>> #include <sys/un.h>
> >>> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
> >>> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
> >>> !defined(HPUX11)
> >>> #include <sys/socketvar.h>
> >>> #endif
> >>> #if !defined(HPUX11) && !defined(AS400)
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >>> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>
> >> --kippdata informationstechnologie GmbH
> >> Bornheimer Str. 33a
> >> 53111 Bonn
> >>
> >> Tel.: 0228/98549-0
> >> Fax: 0228/98549-50
> >> www.kippdata.de
> >> =======================
> >> kippdata informationstechnologie GmbH
> >> Bornheimer Str. 33a
> >> D-53111 Bonn
> >>
> >> Tel.: +49/0228/98549-0
> >> Fax: +49/0228/98549-50
> >> www.kippdata.de
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
> --
> kippdata informationstechnologie GmbH
> Bornheimer Str. 33a
> 53111 Bonn
>
> Tel.: 0228/98549-0
> Fax: 0228/98549-50
> www.kippdata.de
> =======================
> kippdata informationstechnologie GmbH
> Bornheimer Str. 33a
> D-53111 Bonn
>
> Tel.: +49/0228/98549-0
> Fax: +49/0228/98549-50
> www.kippdata.de
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r502649 -
/tomcat/connectors/trunk/jk/native/common/jk_global.h
Posted by Jean-Frederic <jf...@gmail.com>.
Something like:
+++
[[#ifdef HAVE_SYS_SOCKETVAR_H
# include <sys/socketvar.h>
#endif
]])
AC_CHECK_HEADERS([sys/select.h], [], [],
[[#ifdef HAVE_SYS_SELECT_H
# include <sys/select.h>
#endif
]])
+++
helps for sys/socketvar.h
Should we have macros for that?
Cheers
Jean-Frederic
On Fri, 2007-02-02 at 18:36 +0100, Rainer Jung wrote:
> I can't test on HP-UX, but maybe you (jfc) could try:
> Index: configure.in
> ===================================================================
> --- configure.in (revision 502659)
> +++ configure.in (working copy)
> @@ -139,6 +139,10 @@
> dnl check for filio.h used on Solaris to define FIONREAD ioctl.
> AC_CHECK_HEADERS(sys/filio.h)
>
> +dnl check for socketvar.h and select.h not used on HPUX11
> +AC_CHECK_HEADERS(sys/socketvar.h)
> +AC_CHECK_HEADERS(sys/select.h)
> +
> AC_DEFUN([JK_CHECK_SETSOCKOPT], [
> AC_MSG_CHECKING(whether to use $1 with setsockopt())
> AC_TRY_RUN([
> Index: common/jk_global.h
> ===================================================================
> --- common/jk_global.h (revision 502659)
> +++ common/jk_global.h (working copy)
> @@ -142,10 +142,10 @@
> #include <netinet/tcp.h>
> #include <arpa/inet.h>
> #include <sys/un.h>
> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
> !defined(HPUX11)
> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
> !defined(HAVE_SYS_SOCKETVAR_H)
> #include <sys/socketvar.h>
> #endif
> -#if !defined(HPUX11) && !defined(AS400)
> +#if !defined(HAVE_SYS_SELECT_H) && !defined(AS400)
> #include <sys/select.h>
> #endif
> #endif
>
> Of course you would need to rebuild configure via buildconf.sh after
> changing configure.in.
>
> Regards,
>
> Rainer
>
>
> Jim Jagielski wrote:
> > Don't we also have a HPUX11 specific check like
> > the 2nd line after this one? Seems consistent to me :/
> >
> > On Feb 2, 2007, at 12:14 PM, Rainer Jung wrote:
> >
> >> Hi Jean-Frederic,
> >>
> >> shouldn't we be able to find out about the necessity to include it via
> >> configure? At least HP-UX should be able to use the configure
> >> mechanism. I think we mostly use the hard coded defines for the
> >> platforms, where we can't use the configure mechanism.
> >>
> >> Regards,
> >>
> >> Rainer
> >>
> >> jfclere@apache.org wrote:
> >>> Author: jfclere
> >>> Date: Fri Feb 2 08:27:53 2007
> >>> New Revision: 502649
> >>> URL: http://svn.apache.org/viewvc?view=rev&rev=502649
> >>> Log:
> >>> Otherwise it doesn't compile with gcc on HPUX.
> >>> Modified:
> >>> tomcat/connectors/trunk/jk/native/common/jk_global.h
> >>> Modified: tomcat/connectors/trunk/jk/native/common/jk_global.h
> >>> URL:
> >>> http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_global.h?view=diff&rev=502649&r1=502648&r2=502649
> >>>
> >>> ==============================================================================
> >>>
> >>> --- tomcat/connectors/trunk/jk/native/common/jk_global.h (original)
> >>> +++ tomcat/connectors/trunk/jk/native/common/jk_global.h Fri Feb 2
> >>> 08:27:53 2007
> >>> @@ -142,7 +142,7 @@
> >>> #include <netinet/tcp.h>
> >>> #include <arpa/inet.h>
> >>> #include <sys/un.h>
> >>> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
> >>> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
> >>> !defined(HPUX11)
> >>> #include <sys/socketvar.h>
> >>> #endif
> >>> #if !defined(HPUX11) && !defined(AS400)
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >>> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>
> >> --kippdata informationstechnologie GmbH
> >> Bornheimer Str. 33a
> >> 53111 Bonn
> >>
> >> Tel.: 0228/98549-0
> >> Fax: 0228/98549-50
> >> www.kippdata.de
> >> =======================
> >> kippdata informationstechnologie GmbH
> >> Bornheimer Str. 33a
> >> D-53111 Bonn
> >>
> >> Tel.: +49/0228/98549-0
> >> Fax: +49/0228/98549-50
> >> www.kippdata.de
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
> --
> kippdata informationstechnologie GmbH
> Bornheimer Str. 33a
> 53111 Bonn
>
> Tel.: 0228/98549-0
> Fax: 0228/98549-50
> www.kippdata.de
> =======================
> kippdata informationstechnologie GmbH
> Bornheimer Str. 33a
> D-53111 Bonn
>
> Tel.: +49/0228/98549-0
> Fax: +49/0228/98549-50
> www.kippdata.de
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r502649 - /tomcat/connectors/trunk/jk/native/common/jk_global.h
Posted by Jean-frederic Clere <jf...@gmail.com>.
Rainer Jung wrote:
> I can't test on HP-UX, but maybe you (jfc) could try:
The problem is that sys/socketvar.h can't be compiled using gcc and I
think we don't need it HP-UX (for example APR doesn't include it).
I will test the modifications in configure.in later.
Cheers
Jean-Frederic
> Index: configure.in
> ===================================================================
> --- configure.in (revision 502659)
> +++ configure.in (working copy)
> @@ -139,6 +139,10 @@
> dnl check for filio.h used on Solaris to define FIONREAD ioctl.
> AC_CHECK_HEADERS(sys/filio.h)
>
> +dnl check for socketvar.h and select.h not used on HPUX11
> +AC_CHECK_HEADERS(sys/socketvar.h)
> +AC_CHECK_HEADERS(sys/select.h)
> +
> AC_DEFUN([JK_CHECK_SETSOCKOPT], [
> AC_MSG_CHECKING(whether to use $1 with setsockopt())
> AC_TRY_RUN([
> Index: common/jk_global.h
> ===================================================================
> --- common/jk_global.h (revision 502659)
> +++ common/jk_global.h (working copy)
> @@ -142,10 +142,10 @@
> #include <netinet/tcp.h>
> #include <arpa/inet.h>
> #include <sys/un.h>
> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
> !defined(HPUX11)
> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
> !defined(HAVE_SYS_SOCKETVAR_H)
> #include <sys/socketvar.h>
> #endif
> -#if !defined(HPUX11) && !defined(AS400)
> +#if !defined(HAVE_SYS_SELECT_H) && !defined(AS400)
> #include <sys/select.h>
> #endif
> #endif
>
> Of course you would need to rebuild configure via buildconf.sh after
> changing configure.in.
>
> Regards,
>
> Rainer
>
>
> Jim Jagielski wrote:
>
>> Don't we also have a HPUX11 specific check like
>> the 2nd line after this one? Seems consistent to me :/
>>
>> On Feb 2, 2007, at 12:14 PM, Rainer Jung wrote:
>>
>>> Hi Jean-Frederic,
>>>
>>> shouldn't we be able to find out about the necessity to include it
>>> via configure? At least HP-UX should be able to use the configure
>>> mechanism. I think we mostly use the hard coded defines for the
>>> platforms, where we can't use the configure mechanism.
>>>
>>> Regards,
>>>
>>> Rainer
>>>
>>> jfclere@apache.org wrote:
>>>
>>>> Author: jfclere
>>>> Date: Fri Feb 2 08:27:53 2007
>>>> New Revision: 502649
>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=502649
>>>> Log:
>>>> Otherwise it doesn't compile with gcc on HPUX.
>>>> Modified:
>>>> tomcat/connectors/trunk/jk/native/common/jk_global.h
>>>> Modified: tomcat/connectors/trunk/jk/native/common/jk_global.h
>>>> URL:
>>>> http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_global.h?view=diff&rev=502649&r1=502648&r2=502649
>>>>
>>>> ==============================================================================
>>>>
>>>> --- tomcat/connectors/trunk/jk/native/common/jk_global.h (original)
>>>> +++ tomcat/connectors/trunk/jk/native/common/jk_global.h Fri Feb 2
>>>> 08:27:53 2007
>>>> @@ -142,7 +142,7 @@
>>>> #include <netinet/tcp.h>
>>>> #include <arpa/inet.h>
>>>> #include <sys/un.h>
>>>> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
>>>> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
>>>> !defined(HPUX11)
>>>> #include <sys/socketvar.h>
>>>> #endif
>>>> #if !defined(HPUX11) && !defined(AS400)
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>> --kippdata informationstechnologie GmbH
>>> Bornheimer Str. 33a
>>> 53111 Bonn
>>>
>>> Tel.: 0228/98549-0
>>> Fax: 0228/98549-50
>>> www.kippdata.de
>>> =======================
>>> kippdata informationstechnologie GmbH
>>> Bornheimer Str. 33a
>>> D-53111 Bonn
>>>
>>> Tel.: +49/0228/98549-0
>>> Fax: +49/0228/98549-50
>>> www.kippdata.de
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r502649 - /tomcat/connectors/trunk/jk/native/common/jk_global.h
Posted by Rainer Jung <ra...@kippdata.de>.
You are right.
Jim Jagielski wrote:
>
> On Feb 2, 2007, at 12:36 PM, Rainer Jung wrote:
>
>> I can't test on HP-UX, but maybe you (jfc) could try:
>> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
>> !defined(HPUX11)
>> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
>> !defined(HAVE_SYS_SOCKETVAR_H)
>> #include <sys/socketvar.h>
>> #endif
>> -#if !defined(HPUX11) && !defined(AS400)
>> +#if !defined(HAVE_SYS_SELECT_H) && !defined(AS400)
>> #include <sys/select.h>
>> #endif
>> #endif
>>
>
> Hmmm.... Isn't that backwards? Don't we want to
> include these headers if the autoconf macros *are*
> defined?
>
> So why not just:
>
> #if defined(HAVE_SYS_SOCKETVAR_H)
> #include <sys/socketvar.h>
> #endif
> #if defined(HAVE_SYS_SELECT_H)
> #include <sys/select.h>
> #endif
>
> or I must be missing something (wouldn't be the 1st time) :)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
--
kippdata informationstechnologie GmbH
Bornheimer Str. 33a
53111 Bonn
Tel.: 0228/98549-0
Fax: 0228/98549-50
www.kippdata.de
=======================
kippdata informationstechnologie GmbH
Bornheimer Str. 33a
D-53111 Bonn
Tel.: +49/0228/98549-0
Fax: +49/0228/98549-50
www.kippdata.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r502649 - /tomcat/connectors/trunk/jk/native/common/jk_global.h
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Feb 2, 2007, at 12:36 PM, Rainer Jung wrote:
> I can't test on HP-UX, but maybe you (jfc) could try:
> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
> && !defined(HPUX11)
> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
> && !defined(HAVE_SYS_SOCKETVAR_H)
> #include <sys/socketvar.h>
> #endif
> -#if !defined(HPUX11) && !defined(AS400)
> +#if !defined(HAVE_SYS_SELECT_H) && !defined(AS400)
> #include <sys/select.h>
> #endif
> #endif
>
Hmmm.... Isn't that backwards? Don't we want to
include these headers if the autoconf macros *are*
defined?
So why not just:
#if defined(HAVE_SYS_SOCKETVAR_H)
#include <sys/socketvar.h>
#endif
#if defined(HAVE_SYS_SELECT_H)
#include <sys/select.h>
#endif
or I must be missing something (wouldn't be the 1st time) :)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r502649 - /tomcat/connectors/trunk/jk/native/common/jk_global.h
Posted by Rainer Jung <ra...@kippdata.de>.
I can't test on HP-UX, but maybe you (jfc) could try:
Index: configure.in
===================================================================
--- configure.in (revision 502659)
+++ configure.in (working copy)
@@ -139,6 +139,10 @@
dnl check for filio.h used on Solaris to define FIONREAD ioctl.
AC_CHECK_HEADERS(sys/filio.h)
+dnl check for socketvar.h and select.h not used on HPUX11
+AC_CHECK_HEADERS(sys/socketvar.h)
+AC_CHECK_HEADERS(sys/select.h)
+
AC_DEFUN([JK_CHECK_SETSOCKOPT], [
AC_MSG_CHECKING(whether to use $1 with setsockopt())
AC_TRY_RUN([
Index: common/jk_global.h
===================================================================
--- common/jk_global.h (revision 502659)
+++ common/jk_global.h (working copy)
@@ -142,10 +142,10 @@
#include <netinet/tcp.h>
#include <arpa/inet.h>
#include <sys/un.h>
-#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
!defined(HPUX11)
+#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
!defined(HAVE_SYS_SOCKETVAR_H)
#include <sys/socketvar.h>
#endif
-#if !defined(HPUX11) && !defined(AS400)
+#if !defined(HAVE_SYS_SELECT_H) && !defined(AS400)
#include <sys/select.h>
#endif
#endif
Of course you would need to rebuild configure via buildconf.sh after
changing configure.in.
Regards,
Rainer
Jim Jagielski wrote:
> Don't we also have a HPUX11 specific check like
> the 2nd line after this one? Seems consistent to me :/
>
> On Feb 2, 2007, at 12:14 PM, Rainer Jung wrote:
>
>> Hi Jean-Frederic,
>>
>> shouldn't we be able to find out about the necessity to include it via
>> configure? At least HP-UX should be able to use the configure
>> mechanism. I think we mostly use the hard coded defines for the
>> platforms, where we can't use the configure mechanism.
>>
>> Regards,
>>
>> Rainer
>>
>> jfclere@apache.org wrote:
>>> Author: jfclere
>>> Date: Fri Feb 2 08:27:53 2007
>>> New Revision: 502649
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=502649
>>> Log:
>>> Otherwise it doesn't compile with gcc on HPUX.
>>> Modified:
>>> tomcat/connectors/trunk/jk/native/common/jk_global.h
>>> Modified: tomcat/connectors/trunk/jk/native/common/jk_global.h
>>> URL:
>>> http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_global.h?view=diff&rev=502649&r1=502648&r2=502649
>>>
>>> ==============================================================================
>>>
>>> --- tomcat/connectors/trunk/jk/native/common/jk_global.h (original)
>>> +++ tomcat/connectors/trunk/jk/native/common/jk_global.h Fri Feb 2
>>> 08:27:53 2007
>>> @@ -142,7 +142,7 @@
>>> #include <netinet/tcp.h>
>>> #include <arpa/inet.h>
>>> #include <sys/un.h>
>>> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
>>> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&
>>> !defined(HPUX11)
>>> #include <sys/socketvar.h>
>>> #endif
>>> #if !defined(HPUX11) && !defined(AS400)
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>> --kippdata informationstechnologie GmbH
>> Bornheimer Str. 33a
>> 53111 Bonn
>>
>> Tel.: 0228/98549-0
>> Fax: 0228/98549-50
>> www.kippdata.de
>> =======================
>> kippdata informationstechnologie GmbH
>> Bornheimer Str. 33a
>> D-53111 Bonn
>>
>> Tel.: +49/0228/98549-0
>> Fax: +49/0228/98549-50
>> www.kippdata.de
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
--
kippdata informationstechnologie GmbH
Bornheimer Str. 33a
53111 Bonn
Tel.: 0228/98549-0
Fax: 0228/98549-50
www.kippdata.de
=======================
kippdata informationstechnologie GmbH
Bornheimer Str. 33a
D-53111 Bonn
Tel.: +49/0228/98549-0
Fax: +49/0228/98549-50
www.kippdata.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r502649 - /tomcat/connectors/trunk/jk/native/common/jk_global.h
Posted by Jim Jagielski <ji...@jaguNET.com>.
Don't we also have a HPUX11 specific check like
the 2nd line after this one? Seems consistent to me :/
On Feb 2, 2007, at 12:14 PM, Rainer Jung wrote:
> Hi Jean-Frederic,
>
> shouldn't we be able to find out about the necessity to include it
> via configure? At least HP-UX should be able to use the configure
> mechanism. I think we mostly use the hard coded defines for the
> platforms, where we can't use the configure mechanism.
>
> Regards,
>
> Rainer
>
> jfclere@apache.org wrote:
>> Author: jfclere
>> Date: Fri Feb 2 08:27:53 2007
>> New Revision: 502649
>> URL: http://svn.apache.org/viewvc?view=rev&rev=502649
>> Log:
>> Otherwise it doesn't compile with gcc on HPUX.
>> Modified:
>> tomcat/connectors/trunk/jk/native/common/jk_global.h
>> Modified: tomcat/connectors/trunk/jk/native/common/jk_global.h
>> URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/
>> native/common/jk_global.h?view=diff&rev=502649&r1=502648&r2=502649
>> =====================================================================
>> =========
>> --- tomcat/connectors/trunk/jk/native/common/jk_global.h (original)
>> +++ tomcat/connectors/trunk/jk/native/common/jk_global.h Fri Feb
>> 2 08:27:53 2007
>> @@ -142,7 +142,7 @@
>> #include <netinet/tcp.h>
>> #include <arpa/inet.h>
>> #include <sys/un.h>
>> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
>> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
>> && !defined(HPUX11)
>> #include <sys/socketvar.h>
>> #endif
>> #if !defined(HPUX11) && !defined(AS400)
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>
> --
> kippdata informationstechnologie GmbH
> Bornheimer Str. 33a
> 53111 Bonn
>
> Tel.: 0228/98549-0
> Fax: 0228/98549-50
> www.kippdata.de
> =======================
> kippdata informationstechnologie GmbH
> Bornheimer Str. 33a
> D-53111 Bonn
>
> Tel.: +49/0228/98549-0
> Fax: +49/0228/98549-50
> www.kippdata.de
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r502649 - /tomcat/connectors/trunk/jk/native/common/jk_global.h
Posted by Rainer Jung <ra...@kippdata.de>.
Hi Jean-Frederic,
shouldn't we be able to find out about the necessity to include it via
configure? At least HP-UX should be able to use the configure mechanism.
I think we mostly use the hard coded defines for the platforms, where we
can't use the configure mechanism.
Regards,
Rainer
jfclere@apache.org wrote:
> Author: jfclere
> Date: Fri Feb 2 08:27:53 2007
> New Revision: 502649
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=502649
> Log:
> Otherwise it doesn't compile with gcc on HPUX.
>
> Modified:
> tomcat/connectors/trunk/jk/native/common/jk_global.h
>
> Modified: tomcat/connectors/trunk/jk/native/common/jk_global.h
> URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_global.h?view=diff&rev=502649&r1=502648&r2=502649
> ==============================================================================
> --- tomcat/connectors/trunk/jk/native/common/jk_global.h (original)
> +++ tomcat/connectors/trunk/jk/native/common/jk_global.h Fri Feb 2 08:27:53 2007
> @@ -142,7 +142,7 @@
> #include <netinet/tcp.h>
> #include <arpa/inet.h>
> #include <sys/un.h>
> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) && !defined(HPUX11)
> #include <sys/socketvar.h>
> #endif
> #if !defined(HPUX11) && !defined(AS400)
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
--
kippdata informationstechnologie GmbH
Bornheimer Str. 33a
53111 Bonn
Tel.: 0228/98549-0
Fax: 0228/98549-50
www.kippdata.de
=======================
kippdata informationstechnologie GmbH
Bornheimer Str. 33a
D-53111 Bonn
Tel.: +49/0228/98549-0
Fax: +49/0228/98549-50
www.kippdata.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org