You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2014/11/25 20:44:38 UTC
[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/328
[STORM-570] replace table sorter with data table. Also upraded several ...
...javascript libraries to latest versions to make integration simpler.
I know this is kind of a lot. I upgraded to the latest version of several libraries including jquery and bootstrap. Then I replaced table sorter with Data Table and a prebuild bootstrap integration. I configured all of the tables to use DataTable. I enabled pagination and filtering for the tables that make since, and added state storage for all tables. The main index's state is stored in HTML5 local storage, but the other pages have is stored in the HTML 5 SessionStorage so that they are cleaned up eventually, but can remain specific to the topology/component.
The UI looks a bit different, mostly because the default theme for bootstrap changed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-570
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #328
----
commit 5d41020084d625c157966719526cef2e4670f9c1
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2014-11-24T16:21:43Z
[STORM-570] replace table sorter with data table. Also upraded several javascript libraries to latest versions to make integration simpler.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/328#issuecomment-72688638
I rebased it so it would merge cleanly. @kishorvpatil if you could take a look again that would be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/328
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/328#issuecomment-71722168
@revans2 could you please upmerge the change again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/328#issuecomment-64682472
`Tooltip` placing/formatting etc seems to have changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/328#issuecomment-64690420
Thanks for the advice. I switched the style over to be compact for the tables. I also fixed an issue with they layout on fire fox where the table always filled more than the page, and fixed the tooltips. It changed with the update to bootstrap and I missed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/328#issuecomment-83749375
@revans2 Thank you. I have merged in the changes. Sorry for delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/328#issuecomment-67892015
I just upmerged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/328#issuecomment-71722015
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/328#issuecomment-64673038
For dataTables, I would recommend the use of `compact` class to reduce the amount of white-space, instead of `stripe`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---