[GitHub] [activemq-artemis] andytaylor commented on a diff in pull request #4183: ARTEMIS-3875 - adding consumer and producer metrics

[GitBox <gi...@apache.org>]

andytaylor commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r1053274950


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java:
##########
@@ -490,6 +489,7 @@ public void serverSend(ProtonServerReceiverContext context,
             }
          } else {
             message.setConnectionID(receiver.getSession().getConnection().getRemoteContainer());
+            message.setproducerID(receiver.getName());

Review Comment:
   Both AMQ and Openwire create this on the client side so tracking it at the broker wouldnt work. They both use UUIDs. This is how the producers are closed by both



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org