[jira] [Commented] (FLINK-29832) Refactor default database name in flink table store

["Caizhi Weng (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-29832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628619#comment-17628619 ] 

Caizhi Weng commented on FLINK-29832:
-------------------------------------

Hi [~zjureel].

Before diving into your implementation, I'd like to discuss the necessity of this ticket. There are many other catalog (for example, {{HiveCatalog}}) whose default database name is just "default". To switch to this database, we should run {{USE `default`}}, using backtick(`) to escape the keyword.

Why do you think this change is necessary? I'd like to hear your options.

> Refactor default database name in flink table store
> ---------------------------------------------------
>
>                 Key: FLINK-29832
>                 URL: https://issues.apache.org/jira/browse/FLINK-29832
>             Project: Flink
>          Issue Type: Bug
>          Components: Table Store
>    Affects Versions: table-store-0.3.0, table-store-0.2.2
>            Reporter: Shammon
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: image-2022-11-01-16-40-47-539.png
>
>
> `FlinkCatalogFactory` creates a default database named `default` in table store. The `default` is a keyword in SQL, and when we create a new database, we cant execute `use default` to switch to `default` database any more. We should refactor the default database name in table store.
>  !image-2022-11-01-16-40-47-539.png|thumbnail! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)